|
|
Log in / Subscribe / Register

Restricted DMA

From:  Claire Chang <tientzu-AT-chromium.org>
To:  Rob Herring <robh+dt-AT-kernel.org>, mpe-AT-ellerman.id.au, Joerg Roedel <joro-AT-8bytes.org>, Will Deacon <will-AT-kernel.org>, Frank Rowand <frowand.list-AT-gmail.com>, Konrad Rzeszutek Wilk <konrad.wilk-AT-oracle.com>, boris.ostrovsky-AT-oracle.com, jgross-AT-suse.com, Christoph Hellwig <hch-AT-lst.de>, Marek Szyprowski <m.szyprowski-AT-samsung.com>
Subject:  [PATCH v4 00/14] Restricted DMA
Date:  Tue, 09 Feb 2021 14:21:17 +0800
Message-ID:  <20210209062131.2300005-1-tientzu@chromium.org>
Cc:  benh-AT-kernel.crashing.org, paulus-AT-samba.org, "list-AT-263.net:IOMMU DRIVERS" <iommu-AT-lists.linux-foundation.org>, sstabellini-AT-kernel.org, Robin Murphy <robin.murphy-AT-arm.com>, grant.likely-AT-arm.com, xypron.glpk-AT-gmx.de, Thierry Reding <treding-AT-nvidia.com>, mingo-AT-kernel.org, bauerman-AT-linux.ibm.com, peterz-AT-infradead.org, Greg KH <gregkh-AT-linuxfoundation.org>, Saravana Kannan <saravanak-AT-google.com>, "Rafael J . Wysocki" <rafael.j.wysocki-AT-intel.com>, heikki.krogerus-AT-linux.intel.com, Andy Shevchenko <andriy.shevchenko-AT-linux.intel.com>, Randy Dunlap <rdunlap-AT-infradead.org>, Dan Williams <dan.j.williams-AT-intel.com>, Bartosz Golaszewski <bgolaszewski-AT-baylibre.com>, linux-devicetree <devicetree-AT-vger.kernel.org>, lkml <linux-kernel-AT-vger.kernel.org>, linuxppc-dev-AT-lists.ozlabs.org, xen-devel-AT-lists.xenproject.org, Nicolas Boichat <drinkcat-AT-chromium.org>, Jim Quinlan <james.quinlan-AT-broadcom.com>, Claire Chang <tientzu-AT-chromium.org>
Archive-link:  Article

This series implements mitigations for lack of DMA access control on
systems without an IOMMU, which could result in the DMA accessing the
system memory at unexpected times and/or unexpected addresses, possibly
leading to data leakage or corruption.

For example, we plan to use the PCI-e bus for Wi-Fi and that PCI-e bus is
not behind an IOMMU. As PCI-e, by design, gives the device full access to
system memory, a vulnerability in the Wi-Fi firmware could easily escalate
to a full system exploit (remote wifi exploits: [1a], [1b] that shows a
full chain of exploits; [2], [3]).

To mitigate the security concerns, we introduce restricted DMA. Restricted
DMA utilizes the existing swiotlb to bounce streaming DMA in and out of a
specially allocated region and does memory allocation from the same region.
The feature on its own provides a basic level of protection against the DMA
overwriting buffer contents at unexpected times. However, to protect
against general data leakage and system memory corruption, the system needs
to provide a way to restrict the DMA to a predefined memory region (this is
usually done at firmware level, e.g. MPU in ATF on some ARM platforms [4]).

[1a] https://googleprojectzero.blogspot.com/2017/04/over-air-e...
[1b] https://googleprojectzero.blogspot.com/2017/04/over-air-e...
[2] https://blade.tencent.com/en/advisories/qualpwn/
[3] https://www.bleepingcomputer.com/news/security/vulnerabil...
[4] https://github.com/ARM-software/arm-trusted-firmware/blob...

Claire Chang (14):
  swiotlb: Remove external access to io_tlb_start
  swiotlb: Move is_swiotlb_buffer() to swiotlb.c
  swiotlb: Add struct swiotlb
  swiotlb: Refactor swiotlb_late_init_with_tbl
  swiotlb: Add DMA_RESTRICTED_POOL
  swiotlb: Add restricted DMA pool
  swiotlb: Update swiotlb API to gain a struct device argument
  swiotlb: Use restricted DMA pool if available
  swiotlb: Refactor swiotlb_tbl_{map,unmap}_single
  dma-direct: Add a new wrapper __dma_direct_free_pages()
  swiotlb: Add is_dev_swiotlb_force()
  swiotlb: Add restricted DMA alloc/free support.
  dt-bindings: of: Add restricted DMA pool
  of: Add plumbing for restricted DMA pool

 .../reserved-memory/reserved-memory.txt       |  24 +
 arch/powerpc/platforms/pseries/svm.c          |   4 +-
 drivers/iommu/dma-iommu.c                     |  12 +-
 drivers/of/address.c                          |  25 +
 drivers/of/device.c                           |   3 +
 drivers/of/of_private.h                       |   5 +
 drivers/xen/swiotlb-xen.c                     |   4 +-
 include/linux/device.h                        |   4 +
 include/linux/swiotlb.h                       |  32 +-
 kernel/dma/Kconfig                            |  14 +
 kernel/dma/direct.c                           |  51 +-
 kernel/dma/direct.h                           |   8 +-
 kernel/dma/swiotlb.c                          | 636 ++++++++++++------
 13 files changed, 582 insertions(+), 240 deletions(-)

-- 

v4:
  - Fix spinlock bad magic
  - Use rmem->name for debugfs entry
  - Address the comments in v3

v3:
  Using only one reserved memory region for both streaming DMA and memory
  allocation.
  https://lore.kernel.org/patchwork/cover/1360992/

v2:
  Building on top of swiotlb.
  https://lore.kernel.org/patchwork/cover/1280705/

v1:
  Using dma_map_ops.
  https://lore.kernel.org/patchwork/cover/1271660/

2.30.0.478.g8a0d178c01-goog



Copyright © 2021, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds