|
|
Log in / Subscribe / Register

slab: provide and use krealloc_array()

From:  Bartosz Golaszewski <brgl-AT-bgdev.pl>
To:  Andy Shevchenko <andriy.shevchenko-AT-linux.intel.com>, Sumit Semwal <sumit.semwal-AT-linaro.org>, Gustavo Padovan <gustavo-AT-padovan.org>, Christian König <christian.koenig-AT-amd.com>, Mauro Carvalho Chehab <mchehab-AT-kernel.org>, Borislav Petkov <bp-AT-alien8.de>, Tony Luck <tony.luck-AT-intel.com>, James Morse <james.morse-AT-arm.com>, Robert Richter <rric-AT-kernel.org>, Maarten Lankhorst <maarten.lankhorst-AT-linux.intel.com>, Maxime Ripard <mripard-AT-kernel.org>, Thomas Zimmermann <tzimmermann-AT-suse.de>, David Airlie <airlied-AT-linux.ie>, Daniel Vetter <daniel-AT-ffwll.ch>, Alexander Shishkin <alexander.shishkin-AT-linux.intel.com>, Linus Walleij <linus.walleij-AT-linaro.org>, "Michael S . Tsirkin" <mst-AT-redhat.com>, Jason Wang <jasowang-AT-redhat.com>, Christoph Lameter <cl-AT-linux.com>, Pekka Enberg <penberg-AT-kernel.org>, David Rientjes <rientjes-AT-google.com>, Joonsoo Kim <iamjoonsoo.kim-AT-lge.com>, Andrew Morton <akpm-AT-linux-foundation.org>, Jaroslav Kysela <perex-AT-perex.cz>, Takashi Iwai <tiwai-AT-suse.com>
Subject:  [PATCH v3 0/9] slab: provide and use krealloc_array()
Date:  Mon, 09 Nov 2020 12:06:45 +0100
Message-ID:  <20201109110654.12547-1-brgl@bgdev.pl>
Cc:  alsa-devel-AT-alsa-project.org, kvm-AT-vger.kernel.org, linux-mm-AT-kvack.org, netdev-AT-vger.kernel.org, linux-kernel-AT-vger.kernel.org, dri-devel-AT-lists.freedesktop.org, virtualization-AT-lists.linux-foundation.org, linaro-mm-sig-AT-lists.linaro.org, linux-gpio-AT-vger.kernel.org, Bartosz Golaszewski <bgolaszewski-AT-baylibre.com>, linux-media-AT-vger.kernel.org, linux-edac-AT-vger.kernel.org
Archive-link:  Article

From: Bartosz Golaszewski <bgolaszewski@baylibre.com>

Andy brought to my attention the fact that users allocating an array of
equally sized elements should check if the size multiplication doesn't
overflow. This is why we have helpers like kmalloc_array().

However we don't have krealloc_array() equivalent and there are many
users who do their own multiplication when calling krealloc() for arrays.

This series provides krealloc_array() and uses it in a couple places.

A separate series will follow adding devm_krealloc_array() which is
needed in the xilinx adc driver.

v1 -> v2:
- added a kernel doc for krealloc_array()
- mentioned krealloc et al in the docs
- collected review tags

v2 -> v3:
- add a patch improving krealloc()'s kerneldoc
- fix a typo
- improve .rst doc
- tweak line breaks

Bartosz Golaszewski (9):
  mm: slab: clarify krealloc()'s behavior with __GFP_ZERO
  mm: slab: provide krealloc_array()
  ALSA: pcm: use krealloc_array()
  vhost: vringh: use krealloc_array()
  pinctrl: use krealloc_array()
  edac: ghes: use krealloc_array()
  drm: atomic: use krealloc_array()
  hwtracing: intel: use krealloc_array()
  dma-buf: use krealloc_array()

 Documentation/core-api/memory-allocation.rst |  4 ++++
 drivers/dma-buf/sync_file.c                  |  3 +--
 drivers/edac/ghes_edac.c                     |  4 ++--
 drivers/gpu/drm/drm_atomic.c                 |  3 ++-
 drivers/hwtracing/intel_th/msu.c             |  2 +-
 drivers/pinctrl/pinctrl-utils.c              |  2 +-
 drivers/vhost/vringh.c                       |  3 ++-
 include/linux/slab.h                         | 18 ++++++++++++++++++
 mm/slab_common.c                             |  6 +++---
 sound/core/pcm_lib.c                         |  4 ++--
 10 files changed, 36 insertions(+), 13 deletions(-)

-- 
2.29.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel


Copyright © 2020, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds