|
|
Log in / Subscribe / Register

leds: trigger: implement a tty trigger

From:  Uwe Kleine-König <u.kleine-koenig-AT-pengutronix.de>
To:  Jacek Anaszewski <jacek.anaszewski-AT-gmail.com>, Pavel Machek <pavel-AT-ucw.cz>, Dan Murphy <dmurphy-AT-ti.com>, Greg Kroah-Hartman <gregkh-AT-linuxfoundation.org>, Jiri Slaby <jslaby-AT-suse.com>
Subject:  [PATCH v8 0/3] leds: trigger: implement a tty trigger
Date:  Mon, 12 Oct 2020 14:33:55 +0200
Message-ID:  <20201012123358.1475928-1-u.kleine-koenig@pengutronix.de>
Cc:  Johan Hovold <johan-AT-kernel.org>, linux-leds-AT-vger.kernel.org, linux-serial-AT-vger.kernel.org, kernel-AT-pengutronix.de, linux-kernel-AT-vger.kernel.org
Archive-link:  Article

this is v8 of a series adding support for tty triggers. See patch 3 for
how to use it. The first two patches provide the necessary
infrastructure in the tty subsystem to make the trigger possible.

Changes compared to v7 sent with Message-Id
20200707165958.16522-1-u.kleine-koenig@pengutronix.de on 7 Jul 2020:

 - ensure the worker function doesn't monopolize the context it is
   running in
 - Add a missing mutex_unlock in an error path

Pavel Machek wondered in reply to v7 if led_set_brightness was a good
idea. I didn't understand the issue and didn't get a reply to my
question. So if this is indeed a problem, this one still persists.

Best regards
Uwe

Uwe Kleine-König (3):
  tty: rename tty_kopen() and add new function tty_kopen_shared()
  tty: new helper function tty_get_icount()
  leds: trigger: implement a tty trigger

 .../ABI/testing/sysfs-class-led-trigger-tty   |   6 +
 drivers/accessibility/speakup/spk_ttyio.c     |   2 +-
 drivers/leds/trigger/Kconfig                  |   9 +
 drivers/leds/trigger/Makefile                 |   1 +
 drivers/leds/trigger/ledtrig-tty.c            | 187 ++++++++++++++++++
 drivers/tty/tty_io.c                          |  85 +++++---
 include/linux/tty.h                           |   7 +-
 7 files changed, 272 insertions(+), 25 deletions(-)
 create mode 100644 Documentation/ABI/testing/sysfs-class-led-trigger-tty
 create mode 100644 drivers/leds/trigger/ledtrig-tty.c

-- 
2.28.0



Copyright © 2020, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds