| From: |
| John Stultz <john.stultz-AT-linaro.org> |
| To: |
| lkml <linux-kernel-AT-vger.kernel.org> |
| Subject: |
| [RFC][PATCH v3 00/11] HiKey960 USB support |
| Date: |
| Wed, 16 Oct 2019 03:33:29 +0000 |
| Message-ID: |
| <20191016033340.1288-1-john.stultz@linaro.org> |
| Cc: |
| John Stultz <john.stultz-AT-linaro.org>, Greg Kroah-Hartman <gregkh-AT-linuxfoundation.org>, Rob Herring <robh+dt-AT-kernel.org>, Mark Rutland <mark.rutland-AT-arm.com>, ShuFan Lee <shufan_lee-AT-richtek.com>, Heikki Krogerus <heikki.krogerus-AT-linux.intel.com>, Suzuki K Poulose <suzuki.poulose-AT-arm.com>, Chunfeng Yun <chunfeng.yun-AT-mediatek.com>, Yu Chen <chenyu56-AT-huawei.com>, Felipe Balbi <balbi-AT-kernel.org>, Hans de Goede <hdegoede-AT-redhat.com>, Andy Shevchenko <andy.shevchenko-AT-gmail.com>, Jun Li <lijun.kernel-AT-gmail.com>, Valentin Schneider <valentin.schneider-AT-arm.com>, Jack Pham <jackp-AT-codeaurora.org>, linux-usb-AT-vger.kernel.org, devicetree-AT-vger.kernel.org |
| Archive-link: |
| Article |
I'm just trying to pick up a patch series submitted previously
by Yu Chen to get HiKey960 dev-board's USB functionality
working.
The current full patchset can be found here:
https://git.linaro.org/people/john.stultz/android-dev.git...
Previously I sent this series out as two separate series, to
try to make the review a little easier. However, the partial
series was causing some confusion as well, so this time I've
sent almost all of it in one go.
NOTE: I unfortunately don't have any deep knowledge of the
hardware other then the previously submitted code and what I
can intuit from testing, but I tried to document the previously
undocumented bindings as best I could, fixed up a few minor
checkpatch issues and tried to address previous feedback as best
I could.
I'd greatly appreciate feedback or thoughts!
thanks
-john
New in v3:
* Avoiding adding a hisi specific dwc3 binding and instead
trying to make the dwc core binding more flexible as suggsted
by Rob Herring.
* Made the GCTL soft reset unconditional as suggested by
Jack Pham.
* Given the negative feedback on the usb class role-switch
notifier method for the hub logic to hook into, I've reworked
the hub logic to be an usb-role-switch intermediary.
* Lots of minor fixups and cleanups, some reported by the
kbuild test robot <lkp@intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
CC: ShuFan Lee <shufan_lee@richtek.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: Yu Chen <chenyu56@huawei.com>
Cc: Felipe Balbi <balbi@kernel.org>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Jun Li <lijun.kernel@gmail.com>
Cc: Valentin Schneider <valentin.schneider@arm.com>
Cc: Jack Pham <jackp@codeaurora.org>
Cc: linux-usb@vger.kernel.org
Cc: devicetree@vger.kernel.org
John Stultz (6):
dt-bindings: usb: rt1711h: Add connector bindings
dt-bindings: usb: dwc3: Allow clock list & resets to be more flexible
usb: dwc3: Rework clock initialization to be more flexible
usb: dwc3: Rework resets initialization to be more flexible
dt-bindings: usb: generic: Add role-switch-default-host binding
usb: dwc3: Add host-mode as default support
Yu Chen (5):
usb: dwc3: Execute GCTL Core Soft Reset while switch modes
usb: dwc3: Increase timeout for CmdAct cleared by device controller
usb: dwc3: Registering a role switch in the DRD code.
dt-bindings: misc: Add bindings for HiSilicon usb hub and data role
switch functionality on HiKey960
misc: hisi_hikey_usb: Driver to support usb functionality of Hikey960
.../bindings/misc/hisilicon-hikey-usb.txt | 40 ++++
.../devicetree/bindings/usb/dwc3.txt | 5 +-
.../devicetree/bindings/usb/generic.txt | 5 +
.../bindings/usb/richtek,rt1711h.txt | 29 +++
drivers/misc/Kconfig | 6 +
drivers/misc/Makefile | 1 +
drivers/misc/hisi_hikey_usb.c | 178 ++++++++++++++++++
drivers/usb/dwc3/Kconfig | 1 +
drivers/usb/dwc3/core.c | 38 ++--
drivers/usb/dwc3/core.h | 6 +
drivers/usb/dwc3/drd.c | 78 +++++++-
drivers/usb/dwc3/gadget.c | 2 +-
12 files changed, 369 insertions(+), 20 deletions(-)
create mode 100644 Documentation/devicetree/bindings/misc/hisilicon-hikey-usb.txt
create mode 100644 drivers/misc/hisi_hikey_usb.c
--
2.17.1