| From: |
| Linus Torvalds <torvalds-AT-linux-foundation.org> |
| To: |
| David Sterba <dsterba-AT-suse.com> |
| Subject: |
| Re: [PATCH] MAINTAINERS: add myself as maintainer of AFFS |
| Date: |
| Sat, 28 Apr 2018 17:33:57 +0000 |
| Message-ID: |
| <CA+55aFzH=CjVD4kUXfPBjimsKhfphjOceDtcskWtj5Vk3ByB4Q@mail.gmail.com> |
| Cc: |
| Linux Kernel Mailing List <linux-kernel-AT-vger.kernel.org>, Martin Steigerwald <martin-AT-lichtvoll.de>, John Paul Adrian Glaubitz <glaubitz-AT-physik.fu-berlin.de> |
| Archive-link: |
| Article |
On Sat, Apr 28, 2018 at 10:07 AM David Sterba <dsterba@suse.com> wrote:
> I volunteer to act as a maintainer of AFFS to collect any fixes that
> might show up and to guard fs/affs/ against another spring cleaning.
Hmm. Please be more careful.
> @@ -564,8 +564,10 @@ S: Maintained
The above says it adds two lines (8 -> 10), but the actual patch itself
only adds one, and modifies another:
> +M: David Sterba <dsterba@suse.com>
> -S: Orphan
> +S: Odd Fixes
I'm used to editing patches for things like this, because I have years and
years of just hand-editing patches I didn't like for some reason, but it
looks like you tried to edit a patch without knowing all the rules for how
unified patches work.
So please don't edit patches by hand. It's a skill nobody should have.
Anyway, I fixed the patch and applied it, but let's not make a habit of it.
Linus
