|
|
Log in / Subscribe / Register

iomap: Use FUA for O_DSYNC DIO writes

From:  Dave Chinner <david-AT-fromorbit.com>
To:  linux-xfs-AT-vger.kernel.org
Subject:  [PATCH 0/3 v3] iomap: Use FUA for O_DSYNC DIO writes
Date:  Wed, 2 May 2018 15:38:04 +1000
Message-ID:  <20180502053807.13846-1-david@fromorbit.com>
Cc:  linux-fsdevel-AT-vger.kernel.org, linux-block-AT-vger.kernel.org, hch-AT-lst.de, rdorr-AT-microsoft.com
Archive-link:  Article

Hi folks,

Version 3 of the FUA for O-DSYNC patchset. This version fixes bugs
found in the previous version. Functionality is otherwise the same
as described in the first version:

https://marc.info/?l=linux-xfs&m=152213446528167&w=2

Version 3:

- fixed O_SYNC behaviour as noticed by Jan Kara
- fixed use after free on IO completion due
  iomap_dio_complete_work() simplification added in version 2. Found
  by KASAN when running xfstests.

Version 2:
- Fixed comment typos in first patch
- simplified iomap_dio_complete_work()
- changed IOMAP_DIO_WRITE_SYNC to IOMAP_DIO_NEED_SYNC
- split blk_queue_fua() into it's own patch
- fixed formatting issue in last patch
- update bio->io_opf directly rather than use bio_set_op_attrs()
- Updated comment to mention we try to use FUA optimistically.




Copyright © 2018, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds