| From: |
| Javier Arteaga <javier-AT-emutex.com> |
| To: |
| linux-kernel-AT-vger.kernel.org |
| Subject: |
| [RFC PATCH RESEND 0/3] UP Squared board drivers |
| Date: |
| Sat, 21 Apr 2018 09:50:06 +0100 |
| Message-ID: |
| <20180421085009.28773-1-javier@emutex.com> |
| Cc: |
| Javier Arteaga <javier-AT-emutex.com>, Dan O'Donovan <dan-AT-emutex.com>, Andy Shevchenko <andriy.shevchenko-AT-linux.intel.com>, Mika Westerberg <mika.westerberg-AT-linux.intel.com>, Heikki Krogerus <heikki.krogerus-AT-linux.intel.com>, Lee Jones <lee.jones-AT-linaro.org>, Linus Walleij <linus.walleij-AT-linaro.org>, Jacek Anaszewski <jacek.anaszewski-AT-gmail.com>, Pavel Machek <pavel-AT-ucw.cz>, linux-gpio-AT-vger.kernel.org, linux-leds-AT-vger.kernel.org |
| Archive-link: |
| Article |
[linux-kernel correctly Cc'd on the series now. Sorry for the noise.]
Hi all,
This series adds platform support for AAEON's UP Squared, a x86 SBC
based on Apollo Lake [1]. Specifically, it enables control for the board
pin headers and for the LEDs, as both of these features are only
available behind a FPGA-based platform controller.
This is structured around a MFD driver that provides a regmap interface
to that platform controller to each MFD cell.
The series is carved out from an out-of-tree support patchset, initially
written by Dan O'Donovan for the original UP Board [2] and then extended
through the past year to support new entries in the lineup (UP Board, UP
Squared and UP Core) [3].
Here we only submit support for UP Squared to simplify review. Still,
the driver is designed so that it can easily gain support for the other
boards.
Questions:
* Is MFD the right fit for the platform controller?
The intention here is to encapsulate the custom GPIO-bitbanged control
protocol by sharing the regmap between the drivers.
* Is our use of two chained pinctrls (in patch 3/3) valid?
Thank you!
[1]: http://www.up-board.org/upsquared/specifications-up2/
[2]: https://lkml.kernel.org/r/1467648434-29080-1-git-send-ema...
[3]: https://github.com/emutex/ubilinux-kernel/commits/upboard...
Javier Arteaga (3):
mfd: upboard: Add UP2 platform controller driver
leds: upboard: Add LED support
pinctrl: upboard: Add pinctrl and gpio driver
drivers/leds/Kconfig | 10 +
drivers/leds/Makefile | 1 +
drivers/leds/leds-upboard.c | 87 +++++
drivers/mfd/Kconfig | 17 +
drivers/mfd/Makefile | 1 +
drivers/mfd/upboard.c | 273 ++++++++++++++++
drivers/pinctrl/Kconfig | 13 +
drivers/pinctrl/Makefile | 1 +
drivers/pinctrl/pinctrl-upboard.c | 523 ++++++++++++++++++++++++++++++
include/linux/mfd/upboard.h | 70 ++++
10 files changed, 996 insertions(+)
create mode 100644 drivers/leds/leds-upboard.c
create mode 100644 drivers/mfd/upboard.c
create mode 100644 drivers/pinctrl/pinctrl-upboard.c
create mode 100644 include/linux/mfd/upboard.h
--
2.17.0