| From: |
| Steven Rostedt <rostedt-AT-goodmis.org> |
| To: |
| Borislav Petkov <bp-AT-alien8.de> |
| Subject: |
| Re: [RFC PATCH 6/8] EDAC, mce_amd: Convert to seq_buf |
| Date: |
| Fri, 28 Jul 2017 08:59:59 -0400 |
| Message-ID: |
| <20170728085959.126297dc@vmware.local.home> |
| Cc: |
| linux-edac <linux-edac-AT-vger.kernel.org>, Tony Luck <tony.luck-AT-intel.com>, Yazen Ghannam <Yazen.Ghannam-AT-amd.com>, X86 ML <x86-AT-kernel.org>, LKML <linux-kernel-AT-vger.kernel.org> |
On Fri, 28 Jul 2017 12:51:40 +0200
Borislav Petkov <bp@alien8.de> wrote:
> On Fri, Jul 28, 2017 at 09:09:33AM +0200, Borislav Petkov wrote:
> > On Thu, Jul 27, 2017 at 09:47:08PM -0400, Steven Rostedt wrote:
> > > What happens if two CPUs have mce's at the same time? Wouldn't one
> > > corrupt the other buffer. 128 isn't too big to put on the stack is it?
> >
> > Yeah, putting it on the stack is probably safer, just in case.
> >
> > What is even better, though, is if I extended
> > arch/x86/kernel/cpu/mcheck/mce-genpool.c to allocate a second buffer for the
> > decoded strings. We use it for the struct mces right now.
>
> Here's a conversion to a 2-page backed genpool. Seems to work:
Interesting, this is the first I heard of the genpool. I probably could
have used this in other code. Good to know (learn something new every
day :-)
I'll have to take a look at it when I get home later today (still
bouncing between airports).
-- Steve
