Re: [PATCH 0/2] sysctl: allow CLONE_NEWUSER to be disabled
[Posted January 26, 2016 by corbet]
| From: |
| ebiederm-AT-xmission.com (Eric W. Biederman) |
| To: |
| Kees Cook <keescook-AT-chromium.org> |
| Subject: |
| Re: [PATCH 0/2] sysctl: allow CLONE_NEWUSER to be disabled |
| Date: |
| Mon, 25 Jan 2016 13:33:49 -0600 |
| Message-ID: |
| <87bn89sbc2.fsf@x220.int.ebiederm.org> |
| Cc: |
| Andy Lutomirski <luto-AT-amacapital.net>, Andrew Morton <akpm-AT-linux-foundation.org>, Al Viro <viro-AT-zeniv.linux.org.uk>, Richard Weinberger <richard-AT-nod.at>, Robert =?utf-8?B?xZp3acSZY2tp?= <robert-AT-swiecki.net>, Dmitry Vyukov <dvyukov-AT-google.com>, David Howells <dhowells-AT-redhat.com>, Miklos Szeredi <mszeredi-AT-suse.cz>, Kostya Serebryany <kcc-AT-google.com>, Alexander Potapenko <glider-AT-google.com>, Eric Dumazet <edumazet-AT-google.com>, Sasha Levin <sasha.levin-AT-oracle.com>, "linux-doc\@vger.kernel.org" <linux-doc-AT-vger.kernel.org>, "linux-kernel\@vger.kernel.org" <linux-kernel-AT-vger.kernel.org>, "kernel-hardening\@lists.openwall.com" <kernel-hardening-AT-lists.openwall.com> |
| Archive‑link: | |
Article |
Kees Cook <keescook@chromium.org> writes:
>
> Well, I don't know about less weird, but it would leave a unneeded
> hole in the permission checks.
To be clear the current patch has my:
Nacked-by: "Eric W. Biederman" <ebiederm@xmission.com>
The code is buggy, and poorly thought through. Your lack of interest in
fixing the bugs in your patch is distressing.
So broken code, not willing to fix. No. We are not merging this sysctl.
Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
