Private vs public [LWN.net]

Private vs public

Posted Oct 11, 2015 16:38 UTC (Sun) by nix (subscriber, #2304)
In reply to: Private vs public by nevets
Parent article: Sharp: Closing a door

> If you can't handle that, and want to be able to send out "no worries" patches, where if you totally screw up, nobody will criticize you, I'm sorry, you are not fit to submit to a project as serious as the Linux kernel.

That is tantamount to saying that most people from huge chunks of the Earth (where the culture militates against public criticism of people and where people will go to great lengths to avoid such criticism) are not fit to submit to "a project as serious as the Linux kernel".

There's nothing wrong with criticizing the *patches*. There's something wrong with criticizing the *person* -- and you claim above that criticizing the person is just fine. That's pretty horrendous (if you meant it, rather than being a sloppy way of phrasing "nobody will criticize your patches". Obviously if the code is crap, you should say so, but that's not the same thing. Everyone totally screws up now and again. This does not reflect on them except to prove that they are human, and attacking them for that is wrong.)

to post comments

Private vs public

Posted Oct 11, 2015 19:43 UTC (Sun) by lsl (subscriber, #86508) [Link] (2 responses)

> There's nothing wrong with criticizing the *patches*. There's something wrong with criticizing the *person* -- and you claim above that criticizing the person is just fine,

I don't think criticizing a person is generally inappropriate. Sometimes the actual problem is not as much the patches but the mindset that lead to their existence. This is, I think, what Steven's saying.

If you go to great lengths to avoid it, but slip up anyway, well, that happens. The *patch* gets torn apart, you clean it up and everything's fine. But when submitters don't do their due diligence and send crap to the list where it's obvious that they didn't even bother to read the relevant docs, then that's a totally different situation. If you don't even get the most basic stuff right and send one broken patch after another, there's no point in criticizing the individual patches. Until that *person* understands that touching kernel code requires a more careful mindset, looking at the patches is just a waste of time.

So telling those submitters to stop until they change their approach to programming is not only appropriate, but desperately needed. There's more than one way to do that, of course, and no one said you're supposed to scar them for life. With a bit of empathy, you can probably do it without causing all too much pain.

Private vs public

Posted Oct 11, 2015 20:55 UTC (Sun) by neilbrown (subscriber, #359) [Link] (1 responses)

> ...where it's obvious that they didn't even bother to read the relevant docs....

It is *never* obvious what someone else has or hasn't done in private. "They didn't read the relevant docs" may be the simplest explanation that you can think of given your perspective and values.
But people are different and complex. And they change from moment to moment.

Maybe they didn't ready, maybe they read but misunderstood. Maybe they forgot. Maybe they were hasty and careless. Maybe they are having a bad day and they pushed the wrong branch.

That is why attacking the person is such a bad idea. What you are really attacking is your mental model of the person, which is probably quite different in many details to the actual person. You may know what they did publicly,. You never know for certain why. So only attach the actions (i.e the code) not the person.

> If you don't even get the most basic stuff right and send one broken patch after another, there's no point in criticizing the individual patches.

There certainly comes a point where criticizing the patches doesn't seem worth while. But that does not justify attacking the person.

"I'm sorry but I won't be reviewing your patches any more because doing so doesn't appear to help. If you stop posting patches here for at least one month I may then look at future patches you post. If they appear to address my previous review comments, then I may proceed with them"

This talks about what "I" will do, how I see the patches, and specific public actions that you may or may not perform. This is all safe territory. It does not say anything about "you" or the reasons for "your" behaviour. It just identifies the problem and outlines the rules for engagement.

> So telling those submitters to stop until they change their approach to programming

Make that "stop until their patches address the identified issues" and I'll agree with you.

Private vs public

Posted Oct 11, 2015 21:50 UTC (Sun) by neilbrown (subscriber, #359) [Link]

Just a quick addendum...
Modern technological cultures like ours claim to value science over superstition.

Science is about that which is observable and measurable.
Superstition is about whatever we suppose to be the case - untested by measurement.

I'm just suggestion that we should be scientific, not superstitious, in our responses to each other.