Re: [PATCH -v2 6/8] jump_label: Add a new static_key interface
[Posted August 5, 2015 by corbet]
| From: |
| Steven Rostedt <rostedt-AT-goodmis.org> |
| To: |
| Borislav Petkov <bp-AT-alien8.de> |
| Subject: |
| Re: [PATCH -v2 6/8] jump_label: Add a new static_key interface |
| Date: |
| Tue, 4 Aug 2015 10:41:10 -0400 |
| Message-ID: |
| <20150804104110.01676ca1@gandalf.local.home> |
| Cc: |
| Peter Zijlstra <peterz-AT-infradead.org>, Vlastimil Babka <vbabka-AT-suse.cz>, linux-kernel-AT-vger.kernel.org, mingo-AT-kernel.org, jasonbaron0-AT-gmail.com, luto-AT-amacapital.net, tglx-AT-linutronix.de, will.deacon-AT-arm.com, liuj97-AT-gmail.com, rabin-AT-rab.in, ralf-AT-linux-mips.org, ddaney-AT-caviumnetworks.com, benh-AT-kernel.crashing.org, michael-AT-ellerman.id.au, heiko.carstens-AT-de.ibm.com, davem-AT-davemloft.net |
| Archive‑link: | |
Article |
On Tue, 4 Aug 2015 16:33:44 +0200
Borislav Petkov <bp@alien8.de> wrote:
> Hell, we can drop that "key" or "branch" from the whole API for all I
> know. "static_" is enough for me to say what the thing is. But that's
> just me - I like short names - no poems in code and sh*t.
>
> Thoughts, comments?
I agree to get rid of the "key" and the "branch", I never liked them in
the first place.
I prefer static_set_true/false() but I'm also fine with
static_enable/disable() as long as the initializers are consistent.
>
> So yeah, I absolutely see the problematic here and also the need for
> more bikeshedding. And this time, that bikeshedding is important.
>
Right, because the broken part of this nuclear plant, was the bike
shed, and it's color was so ugly that the people in the nuclear plant
kept making mistakes by being distracted by that damn shed!
-- Steve
