Re: [PATCH v2 00/10] evacuate struct page from the block layer, introduce __pfn_t
| From: | Linus Torvalds <torvalds-AT-linux-foundation.org> | |
| To: | Dan Williams <dan.j.williams-AT-intel.com> | |
| Subject: | Re: [PATCH v2 00/10] evacuate struct page from the block layer, introduce __pfn_t | |
| Date: | Thu, 7 May 2015 08:58:41 -0700 | |
| Message-ID: | <CA+55aFyK==+bMHMdfaP4EHjUNseoTWu1-pp2M2WyLVN73ig+_g@mail.gmail.com> | |
| Cc: | Linux Kernel Mailing List <linux-kernel-AT-vger.kernel.org>, Boaz Harrosh <boaz-AT-plexistor.com>, Jan Kara <jack-AT-suse.cz>, Mike Snitzer <snitzer-AT-redhat.com>, Neil Brown <neilb-AT-suse.de>, Benjamin Herrenschmidt <benh-AT-kernel.crashing.org>, Dave Hansen <dave.hansen-AT-linux.intel.com>, Heiko Carstens <heiko.carstens-AT-de.ibm.com>, Chris Mason <clm-AT-fb.com>, Paul Mackerras <paulus-AT-samba.org>, "H. Peter Anvin" <hpa-AT-zytor.com>, Christoph Hellwig <hch-AT-lst.de>, Alasdair Kergon <agk-AT-redhat.com>, "linux-nvdimm-AT-lists.01.org" <linux-nvdimm-AT-lists.01.org>, Ingo Molnar <mingo-AT-kernel.org>, Mel Gorman <mgorman-AT-suse.de>, Matthew Wilcox <willy-AT-linux.intel.com>, Ross Zwisler <ross.zwisler-AT-linux.intel.com>, Rik van Riel <riel-AT-redhat.com>, Martin Schwidefsky <schwidefsky-AT-de.ibm.com>, Jens Axboe <axboe-AT-kernel.dk>, "Theodore Ts'o" <tytso-AT-mit.edu>, "Martin K. Petersen" <martin.petersen-AT-oracle.com>, Juli | |
| Archive‑link: | Article |
On Thu, May 7, 2015 at 8:40 AM, Dan Williams <dan.j.williams@intel.com> wrote:
>
> blkdev_get(FMODE_EXCL) is the protection in this case.
Ugh. That looks like a horrible nasty big hammer that will bite us
badly some day. Since you'd have to hold it for the whole IO. But I
guess it at least works.
Anyway, I did want to say that while I may not be convinced about the
approach, I think the patches themselves don't look horrible. I
actually like your "__pfn_t". So while I (very obviously) have some
doubts about this approach, it may be that the most convincing
argument is just in the code.
Linus