Re: [PATCH 0/2] perf/x86: Add ability to sample TSC [LWN.net]

From:		Ingo Molnar <mingo-AT-kernel.org>
To:		Adrian Hunter <adrian.hunter-AT-intel.com>
Subject:		Re: [PATCH 0/2] perf/x86: Add ability to sample TSC
Date:		Thu, 19 Feb 2015 20:13:21 +0100
Message-ID:		<20150219191321.GA12008@gmail.com>
Cc:		Peter Zijlstra <peterz-AT-infradead.org>, Ingo Molnar <mingo-AT-redhat.com>, Arnaldo Carvalho de Melo <acme-AT-kernel.org>, linux-kernel-AT-vger.kernel.org, David Ahern <dsahern-AT-gmail.com>, Frederic Weisbecker <fweisbec-AT-gmail.com>, Jiri Olsa <jolsa-AT-redhat.com>, Namhyung Kim <namhyung-AT-gmail.com>, Paul Mackerras <paulus-AT-samba.org>, Stephane Eranian <eranian-AT-google.com>, John Stultz <john.stultz-AT-linaro.org>, Thomas Gleixner <tglx-AT-linutronix.de>, Pawel Moll <pawel.moll-AT-arm.com>, Steven Rostedt <rostedt-AT-goodmis.org>, Andi Kleen <ak-AT-linux.intel.com>
Archive‑link:		Article

* Adrian Hunter <adrian.hunter@intel.com> wrote:

> > I suspect you're talking about something else entirely; 
> > your changelogs are inadequate for they tell ntohing of 
> > your usecase and have me guessing. Don't do that.
> 
> Sorry. I did mention Intel PT in patch 2, but I basically 
> assumed the need to synchronize events with other time 
> sources was understood.

Written down, slightly repetitive walk-throughs from first 
concepts to implementation that don't assume too much 
context are very useful to us slightly overworked 
maintainers with an attention span of a slightly retarded 
golden retriever. (Make the story interesting and mix in a 
few jokes and you've got our attention for sure!)

So please do explain verbosely, especially if a review 
discussion turns somewhat discordant, it's a useful tool.

Thanks,

	Ingo