|From:||Vlastimil Babka <email@example.com>|
|To:||firstname.lastname@example.org, Andrew Morton <email@example.com>, David Rientjes <firstname.lastname@example.org>|
|Subject:||[PATCH v3 00/13] compaction: balancing overhead and success rates|
|Date:||Fri, 20 Jun 2014 17:49:30 +0200|
|Cc:||Minchan Kim <email@example.com>, Mel Gorman <firstname.lastname@example.org>, Joonsoo Kim <email@example.com>, Michal Nazarewicz <firstname.lastname@example.org>, Naoya Horiguchi <email@example.com>, Christoph Lameter <firstname.lastname@example.org>, Rik van Riel <email@example.com>, Zhang Yanfei <firstname.lastname@example.org>, email@example.com, Vlastimil Babka <firstname.lastname@example.org>|
Based on next-20140620. This is a v3 of a series (first with proper cover letter) that tries to work simultaneously towards two mutually exclusive goals in memory compaction - reducing overhead and improving success rates. It includes some cleanups and more or less trivial (micro-)optimizations, hopefully more intelligent lock contention management, and some preparation patches that finally result in last two patches that should improve success rates and minimize work that is not likely to result on successful allocation for a THP page fault. There are 3 new patches since last posting, and many have been reworked. Patch 1: a simple change that will make khugepaged not hold uselessly mmap_sem (new) during potentially long sync compaction. I saw more opportunities for improvement there, but that will be for another series. This is rather trivial but still can reduce latencies for m(un)map heavy workloads. Patch 2: fine-grained per-zone deferred compaction management, which should (new) result in more accurate decisions when to compact a particular zone Patch 3: A cleanup/micro-optimization. No change since v2. Patch 4: Another cleanup/optimization. Surprisingly there's still low hanging (new) fruit in functionality that was changed quite recently. Anything that simplifies isolate_migratepages_range() is a good thing... Patch 5: First step towards not relying on need_resched() to limit amount of work done by async compaction. Incorporated feedback since v2 and reworked how lock contention is reported when multiple zones are compacted, so that it's no longer accidental. Patch 6: Prevent running for long time with IRQs disabled, and improve lock contention detection. Incorporated feedback from David. Patch 7: Microoptimization made possible by patch 6. No changes since v2. Patch 8: Reduce some useless rescanning in the free scanner. I made quite major changes based on feedback, so I rather not keep Reviewed-by (thanks Minchan and Zhang though). Patch 9: Reduce some iterations in the migration scanner, and make Patch 13 possible. Based on discussions with David, I made page_order_unsafe() a #define so there will be no doubts about inlining behavior. Patch 10: Cleanup, from David, no changes. Patch 11: Prerequisity for Patch 13, from David, no changes. Patch 12: Improve compaction success rates by grabbing page freed by migration ASAP. Since v2, I've removed the impact on allocation fast paths per Minchan's feedback and changed the rules for when capture is allowed. Patch 13: Minimize work done in page fault direct compaction (i.e. THP) that (RFC) would not lead to successful allocation. Move on to next cc->order aligned block of pages as soon as the scanner encounters a page that is not free and cannot be isolated for migration. Only change since v2 is some cleanup moved to Patch 4 where it fits better. Still a RFC because I see this patch making a difference in stress-highalloc setting that doesn't use __GFP_NO_KSWAPD so it shouldn't be affected. So there is either a bug or unforeseen side-effect. The only thorough evaluation was done when based on pre-3.16-rc1 kernel, with mmtests stress-highalloc benchmark allocating order-9 pages which did not use __GFP_NO_KSWAPD. Patches 1,2,4 were not yet in the series. This is not a benchmark where microoptimizations would be visible, and the settings mean it uses sync compaction and should not benefit from Patch 13 (but it did which is weird). It has however shown improvements in vmstat figures in patches 8, 9 and 12, as documented in the commit messages. I hope David can test if it fixes his issues. Patch 1 was tested separately on another machine, as documented. I'll run further tests with stress-highalloc settings that would mimic THP page faults (i.e. __GFP_NO_KSWAPD). David Rientjes (2): mm: rename allocflags_to_migratetype for clarity mm, compaction: pass gfp mask to compact_control Vlastimil Babka (11): mm, THP: don't hold mmap_sem in khugepaged when allocating THP mm, compaction: defer each zone individually instead of preferred zone mm, compaction: do not recheck suitable_migration_target under lock mm, compaction: move pageblock checks up from isolate_migratepages_range() mm, compaction: report compaction as contended only due to lock contention mm, compaction: periodically drop lock and restore IRQs in scanners mm, compaction: skip rechecks when lock was already held mm, compaction: remember position within pageblock in free pages scanner mm, compaction: skip buddy pages by their order in the migrate scanner mm, compaction: try to capture the just-created high-order freepage mm, compaction: do not migrate pages when that cannot satisfy page fault allocation include/linux/compaction.h | 10 +- include/linux/gfp.h | 2 +- mm/compaction.c | 569 +++++++++++++++++++++++++++++++++------------ mm/huge_memory.c | 20 +- mm/internal.h | 38 ++- mm/page_alloc.c | 122 +++++++--- 6 files changed, 554 insertions(+), 207 deletions(-) -- 184.108.40.206 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to email@example.com More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Copyright © 2014, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds