User: Password:
|
|
Subscribe / Log in / New account

Re: [RFC PATCH 00/28] ktap: A lightweight dynamic tracing tool for Linux

From:  Ingo Molnar <mingo-AT-kernel.org>
To:  Jovi Zhangwei <jovi.zhangwei-AT-gmail.com>
Subject:  Re: [RFC PATCH 00/28] ktap: A lightweight dynamic tracing tool for Linux
Date:  Wed, 2 Apr 2014 09:43:22 +0200
Message-ID:  <20140402074322.GA22744@gmail.com>
Cc:  Alexei Starovoitov <ast-AT-plumgrid.com>, Ingo Molnar <mingo-AT-redhat.com>, Steven Rostedt <rostedt-AT-goodmis.org>, LKML <linux-kernel-AT-vger.kernel.org>, Masami Hiramatsu <masami.hiramatsu.pt-AT-hitachi.com>, Greg Kroah-Hartman <gregkh-AT-linuxfoundation.org>, Frederic Weisbecker <fweisbec-AT-gmail.com>, Daniel Borkmann <dborkman-AT-redhat.com>, Arnaldo Carvalho de Melo <acme-AT-infradead.org>, Peter Zijlstra <a.p.zijlstra-AT-chello.nl>, Thomas Gleixner <tglx-AT-linutronix.de>, Jiri Olsa <jolsa-AT-redhat.com>, Geoff Levand <geoff-AT-infradead.org>
Archive-link:  Article


* Jovi Zhangwei <jovi.zhangwei@gmail.com> wrote:

> So based on all these input, I suggest:
> 
> Put all these community efforts together, figure out the proper 
> design implementation of dynamic tracing tool, ktap can be a good 
> start to build upon it, evolve to a unified kernel script engine 
> with ebpf together, finally service for dynamic tracing and 
> network(if possible).
> 
> Our goal is same and very clearly, we really want a "simple & 
> flexible & safe" dynamic scripting tracing tool for Linux, which 
> could compare or even better than Dtrace, this is the motivation of 
> ktap project.
> 
> Two solution may be take:
>
> 1). upstream ktap into core trace and evolve it step by step, and 
>     finally make a integrated bytecode engine, it's a long process, 
>     but I think it's worth.
> 
> 2). move ktap back into staging, and graduate from staging after the
>     code make tracing people and ebpf people both happy.
> 
> The benefit is the process will be under the eyes of community.
> 
> Ingo, steven, Greg, what do you think?

For now I'm opting for a third option:

  3) Maintain my NAK on the ktap patches until they address the 
     fundamental design concerns outlined by Alexei and others in 
     their review feedback:

     NAKed-by: Ingo Molnar <mingo@kernel.org>

The thing is, I've outlined some of the concerns in my previous 
review. Not much happened on that front, for example ktap did not get 
any closer in integrating with BPF. Many months have passed since the 
previous ktap submission, still I see no progress on the 'design' 
front. That really needs to change.

Please keep me Cc:-ed to any and all future ktap submissions so I can 
monitor ktap's progress and lift the NAK if the design concerns have 
been addressed.

Thanks,

	Ingo


(Log in to post comments)


Copyright © 2014, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds