What's missing from our changelogs: Reverts [LWN.net]

What's missing from our changelogs: Reverts

Posted Jul 26, 2013 18:25 UTC (Fri) by PaulMcKenney (✭ supporter ✭, #9624)
Parent article: What's missing from our changelogs

Eight of these are reverts of earlier commits. Do reverts need Signed-off-by?

to post comments

What's missing from our changelogs: Reverts

Posted Jul 29, 2013 18:32 UTC (Mon) by aliguori (guest, #30636) [Link] (2 responses)

Yes, reverts need a Signed-off-by. git-revert even has a -s option for it.

A revert is not the same thing as making the commit never exist. Often they do not apply cleanly and it's very hard for a reviewer to know whether the author of the revert had to apply logic to resolve conflicts.

What's missing from our changelogs: Reverts

Posted Jul 29, 2013 21:55 UTC (Mon) by PaulMcKenney (✭ supporter ✭, #9624) [Link]

Good to know! Lucky for me that I have never sent a pull request for a reverted commit, I would say. ;-)

What's missing from our changelogs: Reverts

Posted Jul 30, 2013 8:25 UTC (Tue) by jezuch (subscriber, #52988) [Link]

> A revert is not the same thing as making the commit never exist. Often they do not apply cleanly and it's very hard for a reviewer to know whether the author of the revert had to apply logic to resolve conflicts.

It would be useful if revert commits looked like (or simply were) merges. I sometimes do it by hand, but that's awkward.