User: Password:
|
|
Subscribe / Log in / New account

Re: [PATCH v2] net-tcp: TCP/IP stack bypass for loopback connections

From:  David Miller <davem-AT-davemloft.net>
To:  brutus-AT-google.com
Subject:  Re: [PATCH v2] net-tcp: TCP/IP stack bypass for loopback connections
Date:  Tue, 14 Aug 2012 14:22:28 -0700 (PDT)
Message-ID:  <20120814.142228.85041202742435369.davem@davemloft.net>
Cc:  edumazet-AT-google.com, netdev-AT-vger.kernel.org
Archive-link:  Article


Bruce, could you integrate (and unlike your submission, actually build
and run test) Weiping's bug fixes?

Actually, I'm actually a little bit alarmed at Weiping's fixes,
because it makes it look as if you didn't test things at all under
net-next, as it appears that without his fixes any loopback TCP
connection would OOPS the kernel.

In fact, it wouldn't even build without the sysctl_tcp_friends typo.
Indeed:

net/ipv4/tcp.c: In function ‘tcp_recvmsg’:
net/ipv4/tcp.c:1935:35: error: ‘friends’ undeclared (first use in this function)
net/ipv4/tcp.c:1935:35: note: each undeclared identifier is reported only once for each function it
appears in

I hope I don't need to tell you how unacceptable this is.

That also means that all of your measurements in the commit message
weren't even made in the context where this patch will be applied.

Also unacceptable.

All of this makes for an extremely poor quality submission, please
correct these issues.


(Log in to post comments)


Copyright © 2012, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds