User: Password:
|
|
Subscribe / Log in / New account

Re: [PATCH] Taint kernel when lve module is loaded

From:  Rusty Russell <rusty-AT-rustcorp.com.au>
To:  Matthew Garrett <mjg59-AT-srcf.ucam.org>, linux-kernel-AT-vger.kernel.org
Subject:  Re: [PATCH] Taint kernel when lve module is loaded
Date:  Sat, 23 Jun 2012 09:30:52 +0930
Message-ID:  <87zk7usxqj.fsf@rustcorp.com.au>
Cc:  Matthew Garrett <mjg59-AT-srcf.ucam.org>, Alex Lyashkov <umka-AT-cloudlinux.com>
Archive-link:  Article

On Fri, 22 Jun 2012 13:49:31 -0400, Matthew Garrett <mjg59@srcf.ucam.org> wrote:
> Cloudlinux have a product called lve that includes a kernel module. This
> was previously GPLed but is now under a proprietary license, but the
> module continues to declare MODULE_LICENSE("GPL") and makes use of some
> EXPORT_SYMBOL_GPL symbols. Forcibly taint it in order to avoid this.
> 
> Signed-off-by: Matthew Garrett <mjg59@srcf.ucam.org>
> Cc: Alex Lyashkov <umka@cloudlinux.com>
> ---
>  kernel/module.c |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/kernel/module.c b/kernel/module.c
> index 4edbd9c..9ad9ee9 100644
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -2730,6 +2730,10 @@ static int check_module_license_and_versions(struct module *mod)
>  	if (strcmp(mod->name, "driverloader") == 0)
>  		add_taint_module(mod, TAINT_PROPRIETARY_MODULE);
>  
> +	/* lve claims to be GPL but upstream won't provide source */
> +	if (strcmp(mod->name, "lve") == 0)
> +		add_taint_module(mod, TAINT_PROPRIETARY_MODULE);
> +
>  #ifdef CONFIG_MODVERSIONS
>  	if ((mod->num_syms && !mod->crcs)
>  	    || (mod->num_gpl_syms && !mod->gpl_crcs)

Applied, and CC'd -stable.

Thanks,
Rusty.


(Log in to post comments)


Copyright © 2012, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds