|From:||Kay Sievers <kay-AT-vrfy.org>|
|To:||Steven Rostedt <rostedt-AT-goodmis.org>|
|Subject:||Re: [PATCH v2] printk: Have printk() never buffer its data|
|Date:||Mon, 25 Jun 2012 17:22:25 +0200|
|Cc:||Ingo Molnar <mingo-AT-kernel.org>, LKML <linux-kernel-AT-vger.kernel.org>, Linus Torvalds <torvalds-AT-linux-foundation.org>, Ingo Molnar <mingo-AT-elte.hu>, Greg Kroah-Hartman <gregkh-AT-linuxfoundation.org>, Wu Fengguang <fengguang.wu-AT-intel.com>, Andrew Morton <akpm-AT-linux-foundation.org>, Joe Perches <joe-AT-perches.com>, "Paul E. McKenney" <paulmck-AT-us.ibm.com>, Peter Zijlstra <a.p.zijlstra-AT-chello.nl>|
On Mon, Jun 25, 2012 at 4:26 PM, Steven Rostedt <email@example.com> wrote: > On Mon, 2012-06-25 at 15:56 +0200, Ingo Molnar wrote: >> Anyway, bike shed painting aside, the patch looks like a >> workable solution to me. > > Great! Lets hope Kay feels the same way. Hmm, what I still miss, is how the log record export should work properly with unbuffered continuation lines. The buffering of continuation line users resulted in a clean one record per logged line. Now we will get all separated records for all continuation prints of a single line, which would either need to be merged in userspace, or internally. Non-buffered continuation lines and and a record buffer don't play that well with each other. It also sounds like quite a lot of wasted headers in the buffer, which we need to carry around and throw away when we reconstruct the line for output again. If we merge them internally we mess around with the sequence numbers, if we merge them in userspace we would need to export the flags to do that. Kay
Copyright © 2012, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds