Re: [PATCH 1/7] drivers/ide/ide-cs.c: adjust suspicious bit
operation
[Posted June 13, 2012 by corbet]
| From: |
| David Miller <davem-AT-davemloft.net> |
| To: |
| Julia.Lawall-AT-lip6.fr |
| Subject: |
| Re: [PATCH 1/7] drivers/ide/ide-cs.c: adjust suspicious bit
operation |
| Date: |
| Thu, 07 Jun 2012 14:46:16 -0700 (PDT) |
| Message-ID: |
| <20120607.144616.2224976714259476349.davem@davemloft.net> |
| Cc: |
| kernel-janitors-AT-vger.kernel.org, linux-ide-AT-vger.kernel.org,
linux-kernel-AT-vger.kernel.org, joe-AT-perches.com, julia-AT-diku.dk |
| Archive‑link: | |
Article |
From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Wed, 6 Jun 2012 23:41:35 +0200
> - if (!(pdev->resource[0]->flags & IO_DATA_PATH_WIDTH_8)) {
> + if ((p1dev->resource[0]->flags & IO_DATA_PATH_WIDTH)
I'm really surprised someone as thorough as yourself did not
compile test this.
This is just more proof that it's absolutely pointless to make any
changes at all to the old IDE layer. Nobody really cares, and the
risk %99.999 of the time is purely to introduce regressions rather
than make forward progress.
