|From:||"H. Peter Anvin" <hpa-AT-zytor.com>|
|To:||Richard Weinberger <richard-AT-nod.at>|
|Subject:||Re: [PATCH] x86: Merge x86_32 and x86_64 cpu_idle()|
|Date:||Fri, 16 Mar 2012 14:22:24 -0700|
|Cc:||x86-AT-kernel.org, tglx-AT-linutronix.de, mingo-AT-redhat.com, paulmck-AT-linux.vnet.ibm.com, fweisbec-AT-gmail.com, josh-AT-joshtriplett.org, tj-AT-kernel.org, linux-kernel-AT-vger.kernel.org|
On 03/16/2012 01:18 PM, Richard Weinberger wrote: > +/* > + * The idle thread. There's no useful work to be > + * done, so just try to conserve power and have a > + * low exit latency (ie sit in a loop waiting for > + * somebody to say that they'd like to reschedule) > + */ > +void cpu_idle() Thou shalt not, in the language of C, under any circumstances, on the pain of death, declare or define a function with an empty set of parentheses, for though in the language of C++ it meaneth the same as (void), in C it meaneth (...) which is of meaningless as there be no anchor argument by which the types of the varadic arguments can be expressed, and which misleadeth the compiler into allowing unsavory code and in some cases generate really ugly stuff for varadic handling. -hpa
Copyright © 2012, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds