User: Password:
|
|
Subscribe / Log in / New account

Re: [PATCH] mod/file2alias: make modpost compile on darwin again

From:  Rusty Russell <rusty-AT-rustcorp.com.au>
To:  Andreas Bießmann <andreas-AT-biessmann.de>
Subject:  Re: [PATCH] mod/file2alias: make modpost compile on darwin again
Date:  Fri, 24 Feb 2012 14:34:59 +1030
Message-ID:  <877gzc511w.fsf@rustcorp.com.au>
Cc:  Andreas =?utf-8?Q?Bie=C3=9Fmann?= <andreas-AT-biessmann.de>, linux-kernel-AT-vger.kernel.org, gregkh-AT-linuxfoundation.org, Jochen Friedrich <jochen-AT-scram.de>, Samuel Ortiz <sameo-AT-linux.intel.com>, "K. Y. Srinivasan" <kys-AT-microsoft.com>
Archive-link:  Article

On Thu, 23 Feb 2012 07:28:41 +0100, Andreas Bießmann <andreas@biessmann.de> wrote:
> > Oh, and checkpatch.pl is wrong, the code was fine.
> 
> Sorry for that. I was running checkpatch.pl as dutiful patch submitter
> and that complained.

In the Olden Days, we could easily spot code which needed auditing
simply by looking at the (lack of) coding style.  But then someone
decided that the most important attribute of good code was the nature of
the whitespace within it.  And they wrote a tool.

For a while, this made it really hard for us maintainers to tell which
incoming patches we should actually read!  Fortunately, the
Anti-whitespace crusaders have come full circle: we can now tell newbie
coders by the fact that they obey checkpatch.pl.

> Should I provide another version with 'checkpatch' adoptions changed
> back?

Please :)

Thanks,
Rusty.


(Log in to post comments)


Copyright © 2012, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds