User: Password:
|
|
Subscribe / Log in / New account

Re: [PATCH] block: Revert "[SCSI] genhd: add a new attribute "alias" in gendisk"

From:  Kay Sievers <kay.sievers-AT-vrfy.org>
To:  James Bottomley <James.Bottomley-AT-hansenpartnership.com>
Subject:  Re: [PATCH] block: Revert "[SCSI] genhd: add a new attribute "alias" in gendisk"
Date:  Wed, 9 Nov 2011 18:38:21 +0100
Message-ID:  <CAPXgP13x9vvZ3pfW7u=o5rEaTAg_xV7=RC_UFuhk_aRdB4G0vg@mail.gmail.com>
Cc:  Tejun Heo <tj-AT-kernel.org>, Jens Axboe <axboe-AT-kernel.dk>, Nao Nishijima <nao.nishijima.xt-AT-hitachi.com>, Greg Kroah-Hartman <gregkh-AT-suse.de>, Alan Cox <alan-AT-linux.intel.com>, Al Viro <viro-AT-zeniv.linux.org.uk>, linux-kernel-AT-vger.kernel.org, linux-scsi-AT-vger.kernel.org
Archive-link:  Article

On Wed, Nov 9, 2011 at 18:30, James Bottomley
<James.Bottomley@hansenpartnership.com> wrote:
> On Wed, 2011-11-09 at 08:25 -0800, Tejun Heo wrote:

> No, I can't agree with this ... if you propose a working alternative,

The solution to this problem is to let udev log the known symlinks to
the log stream at device discovery time. That way you can log _all_
kernel device messages to the currently know disk names. This works
already even on old systems,

> I'm listening, but in the absence of one, I think the hack fills a gap

There is no gap.

> we have in log analysis and tides us over until we have an agreed on
> proper solution (at which point, I'm perfectly happy to pull the hack
> back out).

Log analysis works just fine with the udev solution and provides the
far better solution to this exact problem, so please revert it.

Such hacks are not supposed to get in, and its really hard to get them
out again.

Thanks,
Kay


(Log in to post comments)


Copyright © 2011, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds