|From:||Linus Torvalds <torvalds-AT-linux-foundation.org>|
|To:||Vasiliy Kulikov <segoon-AT-openwall.com>|
|Subject:||Re: [PATCH v2] kernel: escape non-ASCII and control characters in printk()|
|Date:||Tue, 28 Jun 2011 12:30:14 -0700|
|Cc:||Alan Cox <alan-AT-lxorguk.ukuu.org.uk>, Ingo Molnar <mingo-AT-elte.hu>, Andrew Morton <akpm-AT-linux-foundation.org>, James Morris <jmorris-AT-namei.org>, Namhyung Kim <namhyung-AT-gmail.com>, Greg Kroah-Hartman <gregkh-AT-suse.de>, kernel-hardening-AT-lists.openwall.com, linux-kernel-AT-vger.kernel.org|
On Mon, Jun 27, 2011 at 11:38 AM, Vasiliy Kulikov <firstname.lastname@example.org> wrote: > > Sure, I don't propose it anymore (v2 goes without it). What point would you like to filter things at? I really think that user space should do its own filtering - nobody does a plain 'cat' on dmesg. Or if they do, they really have themselves to blame. And afaik, we don't do any escape sequence handling at the console level either, so you cannot mess up the console with control characters. And the most dangerous character seems to be one that you don't filter: the one we really do react to is '\n', and you could possibly make confusing log messages by embedding a newline in your string and then trying to make the rest look like something bad (say, an oops). So I'm not entirely convinced about this filtering at all. Linus
Copyright © 2011, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds