Re: [PATCH 1/1] perf tools: Add missing user space support for
config1/config2
[Posted May 3, 2011 by corbet]
| From: |
| Vince Weaver <vweaver1-AT-eecs.utk.edu> |
| To: |
| Ingo Molnar <mingo-AT-elte.hu> |
| Subject: |
| Re: [PATCH 1/1] perf tools: Add missing user space support for
config1/config2 |
| Date: |
| Thu, 28 Apr 2011 18:16:22 -0400 (EDT) |
| Message-ID: |
| <alpine.DEB.2.00.1104281811400.25779@cl320.eecs.utk.edu> |
| Cc: |
| Arnaldo Carvalho de Melo <acme-AT-infradead.org>,
linux-kernel-AT-vger.kernel.org, Andi Kleen <ak-AT-linux.intel.com>,
Peter Zijlstra <peterz-AT-infradead.org>,
Stephane Eranian <eranian-AT-gmail.com>,
Lin Ming <ming.m.lin-AT-intel.com>,
Arnaldo Carvalho de Melo <acme-AT-redhat.com>,
Thomas Gleixner <tglx-AT-linutronix.de>,
Peter Zijlstra <a.p.zijlstra-AT-chello.nl> |
| Archive‑link: | |
Article |
On Wed, 27 Apr 2011, Ingo Molnar wrote:
> Secondly, you are still quite wrong even with your revised opinion. Being able
> to type '-e cycles' and '-e instructions' in perf and get ... cycles and
> instructions counts/events, and the kernel helping that kind of approach is not
> 'abstraction to the extreme', it's called 'common sense'.
by your logic I should be able to delete a file by saying
echo "delete /tmp/tempfile" > /dev/sdc1
because using unlink() is too low of an abstraction and confusing to the
user.
> The fact that perfmon and oprofile works via magic vendor-specific event string
> incantations is one of the many design failures of those projects - not a
> virtue.
Well we disagree. I think one of perf_events biggest failings (among
many) is that these generalized event definitions are shoved into the
kernel. At least it bloats the kernel in an option commonly turned on by
vendors. At worst it gives users a full sense of security in thinking
these counters are A). Portable across architectures and B). Actually
measure what they say they do.
I know it is fun to reinvent the wheel, but you ignored decades of
experience in dealing with perf-counters when you ran off and invented
perf_events. It will bite you eventually.
Vince
