User: Password:
|
|
Subscribe / Log in / New account

Re: [PATCH 0/3] Extended file stat functions [ver #2]

From:  Christoph Hellwig <hch-AT-infradead.org>
To:  David Howells <dhowells-AT-redhat.com>
Subject:  Re: [PATCH 0/3] Extended file stat functions [ver #2]
Date:  Wed, 30 Jun 2010 08:11:28 -0400
Cc:  Andreas Dilger <adilger-AT-dilger.ca>, viro-AT-ZenIV.linux.org.uk, smfrench-AT-gmail.com, jlayton-AT-redhat.com, mcao-AT-us.ibm.com, aneesh.kumar-AT-linux.vnet.ibm.com, linux-cifs-AT-vger.kernel.org, linux-fsdevel-AT-vger.kernel.org, linux-kernel-AT-vger.kernel.org, samba-technical-AT-lists.samba.org, sjayaraman-AT-suse.de, linux-ext4-AT-vger.kernel.org
Archive-link:  Article, Thread

On Wed, Jun 30, 2010 at 01:05:44PM +0100, David Howells wrote:
> My aim was to avoid the need to create new stat syscalls in the future by
> making it possible to increment the version number you're asking for.

The cost of adding a syscall is much smaller than adding all the wanking
in your system call.  Think about it - adding a new stat variant if a
few lines of code which add minimal icache footpint.  Even less so when
the applications using the old ones disappear for a while.  Totally
overdesigned crap like yours on the other hand adds lots of code and
branches that stay forever.  In addition to making life for strace and
co really hard if the structure ever changes.

So adding a few fields of padding at the end for new members is fine,
but doing overkill of versioning including queries for supported
versions doesn't.

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html



(Log in to post comments)


Copyright © 2010, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds