|From:||Greg KH <gregkh-AT-suse.de>|
|To:||Tejun Heo <tj-AT-kernel.org>|
|Subject:||Re: [PATCH 12/12] usb: use IRQ watching|
|Date:||Mon, 14 Jun 2010 14:41:22 -0700|
|Cc:||mingo-AT-elte.hu, tglx-AT-linutronix.de, bphilips-AT-suse.de, yinghai-AT-kernel.org, akpm-AT-linux-foundation.org, torvalds-AT-linux-foundation.org, linux-kernel-AT-vger.kernel.org, jeff-AT-garzik.org, linux-ide-AT-vger.kernel.org, stern-AT-rowland.harvard.edu, khali-AT-linux-fr.org|
On Sun, Jun 13, 2010 at 05:31:38PM +0200, Tejun Heo wrote: > Ask IRQ subsystem to watch HCD IRQ line after initialization. This at > least keeps USB ports which are occupied on initialization working and > eases bug reporting and debugging. > > Signed-off-by: Tejun Heo <email@example.com> > --- > drivers/usb/core/hcd.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c > index 12742f1..383875f 100644 > --- a/drivers/usb/core/hcd.c > +++ b/drivers/usb/core/hcd.c > @@ -2270,6 +2270,7 @@ int usb_add_hcd(struct usb_hcd *hcd, > "request interrupt %d failed\n", irqnum); > goto err_request_irq; > } > + watch_irq(irqnum, hcd); So if there's a routing problem, it turns into a polled interrupt? Do we really want that? I wonder how long people will run without realizing that there are problems with their system if their devices still work. Other than that minor comment, it all looks good to me. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to firstname.lastname@example.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Copyright © 2010, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds