User: Password:
Subscribe / Log in / New account

[20/93] drm/i915: Increase fb alignment to 64k

From:  Greg KH <>
Subject:  [20/93] drm/i915: Increase fb alignment to 64k
Date:  Fri, 19 Feb 2010 08:29:13 -0800
Cc:,,,, Chris Wilson <>, Eric Anholt <>
Archive-link:  Article, Thread

2.6.32-stable review patch.  If anyone has any objections, please let us know.


From: Chris Wilson <>

commit fd2e8ea597222b8f38ae8948776a61ea7958232e upstream.

An untiled framebuffer must be aligned to 64k. This is normally handled
by intel_pin_and_fence_fb_obj(), but the intelfb_create() likes to be
different and do the pinning itself. However, it aligns the buffer
object incorrectly for pre-i965 chipsets causing a PGTBL_ERR when it is
installed onto the output.

  KMS error message while initializing modesetting -
  render error detected: EIR: 0x10 [i915]

Signed-off-by: Chris Wilson <>
Signed-off-by: Eric Anholt <>
Signed-off-by: Greg Kroah-Hartman <>

 drivers/gpu/drm/i915/intel_fb.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/gpu/drm/i915/intel_fb.c
+++ b/drivers/gpu/drm/i915/intel_fb.c
@@ -148,7 +148,7 @@ static int intelfb_create(struct drm_dev
-	ret = i915_gem_object_pin(fbo, PAGE_SIZE);
+	ret = i915_gem_object_pin(fbo, 64*1024);
 	if (ret) {
 		DRM_ERROR("failed to pin fb: %d\n", ret);
 		goto out_unref;

(Log in to post comments)

Copyright © 2010, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds