User: Password:
|
|
Subscribe / Log in / New account

Re: [RFC,PATCH 0/14] utrace/ptrace

From:  Christoph Hellwig <hch-AT-infradead.org>
To:  Oleg Nesterov <oleg-AT-redhat.com>
Subject:  Re: [RFC,PATCH 0/14] utrace/ptrace
Date:  Wed, 25 Nov 2009 16:48:18 -0500
Cc:  Alexey Dobriyan <adobriyan-AT-gmail.com>, Ananth Mavinakayanahalli <ananth-AT-in.ibm.com>, Christoph Hellwig <hch-AT-infradead.org>, "Frank Ch. Eigler" <fche-AT-redhat.com>, Ingo Molnar <mingo-AT-elte.hu>, Peter Zijlstra <peterz-AT-infradead.org>, Roland McGrath <roland-AT-redhat.com>, linux-kernel-AT-vger.kernel.org, utrace-devel-AT-redhat.com
Archive-link:  Article, Thread

On Tue, Nov 24, 2009 at 09:01:27PM +0100, Oleg Nesterov wrote:
> Hello.
> 
> This is the new iteration of Roland's utrace patch, this time
> with "rewrite-ptrace-via-utrace" + cleanups in utrace core.
> 
> 1-7 are already in -mm tree, I am sending them to simplify the
> review.
> 
> 8-12 don not change the behaviour, simple preparations.
> 
> 13-14 add utrace-ptrace and utrace

Skipped over it very, very briefly.  One thing I really hate about this
is that it introduces two ptrace implementation by adding the new one
without removing the old one.  Given that's it's pretty much too later
for the 2.6.33 cycle anyway I'd suggest you make sure the remaining
two major architectures (arm and mips) get converted, and if the
remaining minor architectures don't manage to get their homework done
they're left without ptrace.

The other thing is that this patchset really doesn't quite justify
utrace.  It's growing a lot more code without actually growing any
useful functionality.  What about all those other utrace killer
features that have been promised for a long time?



(Log in to post comments)


Copyright © 2009, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds