User: Password:
|
|
Subscribe / Log in / New account

Re: [PATCH 1/7] block: Add block_flush_device()

From:  Ric Wheeler <rwheeler-AT-redhat.com>
To:  Linus Torvalds <torvalds-AT-linux-foundation.org>
Subject:  Re: [PATCH 1/7] block: Add block_flush_device()
Date:  Mon, 30 Mar 2009 22:14:58 -0400
Message-ID:  <49D17CA2.5060105@redhat.com>
Cc:  Jens Axboe <jens.axboe-AT-oracle.com>, =?ISO-8859-1?Q?Fernando_Luis_?= =?ISO-8859-1?Q?V=E1zquez_Cao?= <fernando-AT-oss.ntt.co.jp>, Jeff Garzik <jeff-AT-garzik.org>, Christoph Hellwig <hch-AT-infradead.org>, Theodore Tso <tytso-AT-mit.edu>, Ingo Molnar <mingo-AT-elte.hu>, Alan Cox <alan-AT-lxorguk.ukuu.org.uk>, Arjan van de Ven <arjan-AT-infradead.org>, Andrew Morton <akpm-AT-linux-foundation.org>, Peter Zijlstra <a.p.zijlstra-AT-chello.nl>, Nick Piggin <npiggin-AT-suse.de>, David Rees <drees76-AT-gmail.com>, Jesper Krogh <jesper-AT-krogh.cc>, Linux Kernel Mailing List <linux-kernel-AT-vger.kernel.org>, chris.mason-AT-oracle.com, david-AT-fromorbit.com, tj-AT-kernel.org
Archive-link:  Article

Linus Torvalds wrote:
> On Mon, 30 Mar 2009, Jens Axboe wrote:
>   
>>> It has _nothing_ to do with 'reckless'. It has everything to do with 'you 
>>> can't do anything about it'.
>>>       
>> No, but you better damn well inform of such a discovery!
>>     
>
> Well, if that's the issue, then just add a printk to that 
> 'blkdev_issue_flush()', and now you have that informational message in 
> _one_ place, instead of havign each filesystem having to do it over and 
> over again.
>
>   
>>> No. Returning an error just means that now the box is useless. Nobody can 
>>> do anything about it. Not the admin, not the driver writer, not anybody. 
>>>       
>> What, that's nonsense. The admin can certainly check whether it's an
>> issue or not, and he should.
>>     
>
> If it's just informational, then again - why should the filesystem care?
>
> Returning an error to the caller is never the right thing to do. The 
> caller can't do anything sane about it.
>
> If you argue that the admin wants to know, then sure, make that
>
>                 if (bio_flagged(bio, BIO_EOPNOTSUPP))
>         -               ret = -EOPNOTSUPP;
>         +               set_queue_noflush(q);
>
> "set_queue_noflush()" function print a warning message when it sets the 
> bit.
>
> Problem solved.
>
>   
>> That's different from handling it in the kernel or in the application, 
>> but you have to inform about it. I honestly cannot fathom why you don't 
>> think that is important.
>>     
>
> I cannot fathom why you can _possibly_ think that this is something that 
> can and must be done something about in the caller. When the caller 
> obviously has no real option except to ignore the error _anyway_.
>
> That was always my point. Returning an error is INSANE, because ther is no 
> valid thing that the caller can possibly do.
>
> If you want it logged, fine. But THAT DOES NOT CHANGE ANYTHING. It would 
> still be wrong to return the error, since the caller _still_ can't do 
> anything about it.
>
> 		Linus
>   

One thing the caller could do is to disable the write cache on the 
device. A second would be to stop using the transactions - skip the 
journal, just go back to ext2 mode or BSD like soft updates.

Basically, it lets the file system know that its data integrity building 
blocks are not really there and allows it (if it cares) to try and 
minimize the chance of data loss.

Ric



(Log in to post comments)


Copyright © 2009, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds