There's lowering the barrier for entry, and there's not having a barrier at all. The latter is what I'm concerned that staging/ has become.
I strongly support the notion that high-level review is only warranted on code that is reviewable and looks tasteful, and that code which doesn't meet basic style should not be merged at all.
But you're operating on a completely different level!
You chose this example to demonstrate, by (if I may) expandio ad absurdum, that our current approach is flawed. Obviously you *knew* that it could be converted to a pointer, and equally obviously this would require us to process relocations before parsing version symbols. Clearly, you understood that this would mean we had to find another solution for struct module versioning, but you knew that that was always the first symbol version anyway.
You no-doubt knew that we could potentially save 7% on our module size using this approach. But obviously not wanting to criticize my code, you instead chose this oh-so-subtle intimation where I would believe the triumph to be mine alone!
I am humbled by your genius, and I only hope that my patch series approaches the Nirvanic perfection you foresaw.
Copyright © 2009, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds