User: Password:
|
|
Subscribe / Log in / New account

Getting the right kind of contributions

Getting the right kind of contributions

Posted May 28, 2008 20:32 UTC (Wed) by sbergman27 (guest, #10767)
In reply to: Getting the right kind of contributions by drosser
Parent article: Getting the right kind of contributions

"""
So why aren't these trivial patches being referred to Kernel Janitors?
"""

That is a good question.  But I will point out that "trivial" is quite a relative thing.
"Coding Style" was a significant theme when devfs was being battled out on the list.  And as I
recall, Al didn't think that it was trivial when he was beating Richard Gooch over the head
with it.  Why now?


(Log in to post comments)

Getting the right kind of contributions

Posted May 28, 2008 22:18 UTC (Wed) by nix (subscriber, #2304) [Link]

Coding style is one thing. *Alignment of parentheses* is another.

(And yes, when I'm maintaining other people's code I do realign them if 
they're misaligned and I'm working in that area: but submitting patches 
that do nothing else is barmy.)

Getting the right kind of contributions

Posted May 29, 2008 8:50 UTC (Thu) by Los__D (guest, #15263) [Link]

I do think that if one is already changing a line which is incorrectly laid out then there's no point in _leaving_ it incorrect. There's no downside to fixing it. That being said, it's often sorely tempting to go hunting down nearby sillinesses. I succumb to that temptation and usually won't complain when others do also, up to a point.

-- Andrew Morton (Shamelessly stolen from Kerneltrap's quotes)

Getting the right kind of contributions

Posted May 29, 2008 23:29 UTC (Thu) by viro (subscriber, #7872) [Link]

As the matter of fact, devfs *had* multiline argument lists aligned.
Which had zero impact on readability...

There's one thing sadly missing in all that mess, as you've just shown.
Common sense.  Note that with all the rules in Documentation/CodingStyle,
the common sense is not even mentioned there anymore...

Getting the right kind of contributions

Posted May 30, 2008 16:57 UTC (Fri) by nix (subscriber, #2304) [Link]

One would hope that common sense is kind of assumed.

(OK, OK, I know...)


Copyright © 2017, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds