In his first line he gave the context of debugging applications. He never gave a patch. He pointed to a couple lines. Nor did he give any any context to the two lines he was talking about, other than the #ifndef PURIFY around the second line. The fact that he gave no context is huge for me, because it makes no sense to comment out lines that generate warnings without looking at the context of those lines. Finally, nobody "signed off" on anything. One guy said, "If it helps with debugging, I'm in favor of removing them." That's not the same as, "sure, they're useless lines, delete them for production. And then give that version to countless people to run in production too."
Copyright © 2017, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds