At least one part of the bug was that it was making Valgrind spew out warnings when trying to debug user programs. The warnings themselves were the visible part of the bug. He did not say "if it was ok to comment out two lines of code, "when debugging applications"." He asked if it was okay to comment out two lines of code, nothing about limiting when. And even if it did help with debugging, surely the optimal response would point out that the result would be a dangerously crippled library? A lot of debugging systems make it out into the real world so problems can be discovered without installing a special "debuggable" version of the program. Kurt should have made it more clear what he was going to do with the patch, but the people replying should have taken a better look at the patch even without that. A bad patch is not just the fault of its creator; everyone who signs off on it also has to take some part of the blame.
Copyright © 2017, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds