User: Password:
|
|
Subscribe / Log in / New account

Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

From:  Herbert Xu <herbert-AT-gondor.apana.org.au>
To:  Andi Kleen <andi-AT-firstfloor.org>
Subject:  Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.
Date:  Tue, 27 Nov 2007 22:36:01 +0800
Message-ID:  <20071127143601.GA6080@gondor.apana.org.au>
Cc:  rusty-AT-rustcorp.com.au, rdreier-AT-cisco.com, ak-AT-suse.de, netdev-AT-vger.kernel.org, linux-kernel-AT-vger.kernel.org, sam-AT-ravnborg.org
Archive-link:  Article

On Tue, Nov 27, 2007 at 03:12:42PM +0100, Andi Kleen wrote:
>
> For Networking: e.g. symbols i put into inet, which are only
> used by protocols (sctp, dccp, udplite, ipv6)

Wait, that's exactly Rusty's point (I think :)

These symbols are exported because they're needed by protocols.
If they weren't available to everyone then it would be difficult
to start writing new protocols.

> I already caught someone doing something wrong with that BTW -- 
> wanrouter clearly does some things it shouldn't be doing. 

Can you be more precise?

> Or the fib namespace, where all the fib functions should be only
> used by the two fib_* modules and ipv6/decnet.

Again, if it's used by decnet then it sounds like it should be
exported because new protocol families may need them.

So based on the network code at least I'm kind of starting to
agree with Rusty now: if a symbol is needed by more than one
in-tree module chances are we want it to be exported for all.

Although I admit I haven't examined your examples elsewhere.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html



(Log in to post comments)


Copyright © 2007, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds