User: Password:
Subscribe / Log in / New account

Re: [-mm patch] unexport sys_{open,read}

From:  Andrew Morton <>
To:  Christoph Hellwig <>
Subject:  Re: [-mm patch] unexport sys_{open,read}
Date:  Mon, 10 Sep 2007 02:23:24 -0700
Message-ID:  <>
Cc:  Adrian Bunk <>,,
Archive-link:  Article

On Mon, 10 Sep 2007 10:08:08 +0100 Christoph Hellwig <> wrote:

> On Sun, Sep 09, 2007 at 02:59:40PM -0700, Andrew Morton wrote:
> > Sure.  But I think it is better to give people some warning when we're
> > planning on breaking out-of-tree things.  I do occasionally receive reports
> > of "hey, the X driver which I get from Y doesn't work any more".  Often
> > it's open-source stuff, too.  I see no point in irritating our users more than
> > we need to.
> There is no fucking reason they should have used it in the first place.

fucking except fucking we fucking exported fucking it fucking so fucking
they fucking used fucking it.  fucking.

Hey, this would be easier with a sed script!  And it so improves the

> Until we have something like a coherent export API instead of random crap
> exported because someone once needed it to do a dumb thing it'll happen.
> Only way to avoid it is to merge the driver and shake out their dumb ideas
> in the review process.

Well that's why I agreed that we should remove those exports.

> > Adrian knows this, yet he habitually sends zero-warning export-removal
> > patches and I habitually ignore them.  I guess we must both enjoy this or
> > something.
> And I think almost everyone disagrees with you.  We just carry too much
> crap around because of your subborness in this issue, and it gets really
> annoying to have some high up on the food chain fighting his longly flight
> against the other people.

I would like to see "everyone" explain what we lose by giving developers a
bit of warning before we break their stuff.

And it would need to be a good explanation, Christoph.  A measured one
which recognises and then weighs the tradeoffs involved, and the costs.  An
inebriated-sounding rant will not impress, sorry.

(Log in to post comments)

Copyright © 2007, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds