| From: |
| Steven Rostedt <rostedt@goodmis.org> |
| To: |
| LKML <linux-kernel@vger.kernel.org> |
| Subject: |
| [RFC PATCH 0/5 v2] Convert all tasklets to workqueues V2 |
| Date: |
| Fri, 22 Jun 2007 14:20:51 -0400 |
| Cc: |
| Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Christoph Hellwig <hch@infradead.org>,
john stultz <johnstul@us.ibm.com>,
Oleg Nesterov <oleg@tv-sign.ru>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Dipankar Sarma <dipankar@in.ibm.com>,
"David S. Miller" <davem@davemloft.net>, kuznet@ms2.inr.ac.ru |
--
This is version 2 of the tasklet to workqueue conversion.
Changes from version 1.
- removed config option and simply replace the old implementation
with the work queue one (recommended by Ingo Molnar).
- replaced clear_bit with test_and_clear_bit to avoid the race of
executing the tasklet function twice. (thanks to Oleg Nesterov
for pointing that out).
- Removed most of the pr_debug prints. (Kept one)
(recommended by Ingo Molnar)
- Removed call to softirq_init.
- Added Author credit to Dipankar Sarma for the RCU tasklet to
softirq conversion.
- Tested on my Powerbook to add another arch to the mix :-)
Funny that booting with this change was the first time that
the bcm43xx didn't get stuck for several seconds on bootup.
It's also one of the few drivers that use tasklet_disable_nosync.
So either this shows that the change fixed something, or that
it broke something (or was just a fluke).
-- Steve
