|From:||Hugh Dickins <hugh-AT-veritas.com>|
|To:||Andrew Morton <akpm-AT-linux-foundation.org>|
|Subject:||Re: 2.6.22 -mm merge plans: slub|
|Date:||Tue, 1 May 2007 19:10:29 +0100 (BST)|
|Cc:||Christoph Lameter <clameter-AT-sgi.com>, linux-kernel-AT-vger.kernel.org, linux-mm-AT-kvack.org|
On Mon, 30 Apr 2007, Andrew Morton wrote: > > i386-use-page-allocator-to-allocate-thread_info-structure.patch > slub-core.patch > > slub. Or part thereof. This is another patch series which got messed up by > poor patch sequencing. > > make-page-private-usable-in-compound-pages-v1.patch > optimize-compound_head-by-avoiding-a-shared-page.patch > add-virt_to_head_page-and-consolidate-code-in-slab-and-slub.patch > slub-fix-object-tracking.patch > slub-enable-tracking-of-full-slabs.patch > slub-validation-of-slabs-metadata-and-guard-zones.patch > slub-add-min_partial.patch > slub-add-ability-to-list-alloc--free-callers-per-slab.patch > slub-free-slabs-and-sort-partial-slab-lists-in-kmem_cache_shrink.patch > slub-remove-object-activities-out-of-checking-functions.patch > slub-user-documentation.patch > slub-add-slabinfo-tool.patch > > Most of the rest of slub. Will merge it all. Merging slub already? I'm surprised. That's a very key piece of infrastructure, and I doubt it's had the exposure it needs yet. Just what has it been widely tested on so far? x86_64. Not many of us have ia64, but I guess SGI people will have been trying it on that. Not i386, that's excluded. Not powerpc - hmm, I thought that was known, but looking I see no ARCH_USES_SLAB_PAGE_STRUCT there: just built and tried to run it up, crashes in slab_free from pgtable_free_tlb frpm free_pte_range from free_pgd_range from free_pgtables from unmap_region form do_munmap. That's 2.6.21-rc7-mm2. slob has a justified place at the low end, but do we want some people running with slab and some with slub? I'd expected slub to stay in 2.6.22-mm, and have all the architectures cut over to it in that time, before advancing to mainline. I've nothing against slub in itself, though I'm wary of its cache merging (more scope for one corrupting another) (and sometimes I think Christoph spent one life uglifying slab for NUMA, then another life ripping that all out to make slub ;) Hugh
Copyright © 2007, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds