Re: [GIT PATCH] UIO patches for 2.6.21
[Posted May 2, 2007 by corbet]
| From: |
| Andrew Morton <akpm-AT-linux-foundation.org> |
| To: |
| Greg KH <gregkh-AT-suse.de> |
| Subject: |
| Re: [GIT PATCH] UIO patches for 2.6.21 |
| Date: |
| Fri, 27 Apr 2007 16:04:25 -0700 |
| Cc: |
| Linus Torvalds <torvalds-AT-linux-foundation.org>,
linux-kernel-AT-vger.kernel.org, tglx-AT-linutronix.de,
Benedikt Spranger <b.spranger-AT-linutronix.de>,
"Hans J. Koch" <hjk-AT-linutronix.de> |
On Fri, 27 Apr 2007 15:49:57 -0700
Greg KH <gregkh@suse.de> wrote:
> Here are the updated UIO (Userspace I/O driver framework) patches for
> 2.6.21.
I'm a bit uncertain about the whole UIO idea, really. I have this vague
feeling that we'd prefer to encourage people to move device drivers into
GPL'ed kernel rather than encouraging them to do closed-source userspace
implementations which will probably end up being slower, less reliable and
unavailable on various architectures, distros, etc.
But I don't think I have the capacity to actually think about this further
- just tossing it out there ;)
> They have been revamped from the last time you have seen them, and they
> include a real driver, the Hilscher CIF DeviceNet and Profibus card
> controller, which is being used in production systems with this driver
> framework right now. The kernel driver they replaced was a total mess,
> with over 60+ ioctls to try to control the different aspects of the
> device. See the last patch in this series for more details on this
> driver.
>
> These patches include full documentation, are self-contained from the
> rest of the kernel, and have been in the -mm tree for the past few
> months with no complaints.
>
> Please pull from:
> master.kernel.org:/pub/scm/linux/kernel/git/gregkh/uio-2.6.git/
>
> Patches will be sent as a follow-on to this message to lkml for people
> to see.
>
> drivers/uio/uio_cif.c | 156 ++++++++
eh? How come a particular device requires 156 lines of kernel code to
support a userspace driver? Doesn't that kind of defeat the point?