User: Password:
|
|
Subscribe / Log in / New account

OpenBSD bcw: Possible GPL license violation issues

From:  Michael Buesch <mb-fseUSCV1ubazQB+pC5nmwQ-AT-public.gmane.org>
To:  Marcus Glocker <mglocker-7YlrpqBBQ3VAfugRpC6u6w-AT-public.gmane.org>, Jon Simola <jsimola-Re5JQEeQqe8AvxtiuMwx3w-AT-public.gmane.org>, Theo de Raadt <deraadt-T7FYYhErWq4AvxtiuMwx3w-AT-public.gmane.org>, Stefano Brivio <stefano.brivio-hl5o88x/ua9eoWH0uzbU5w-AT-public.gmane.org>, Martin Langer <martin-langer-Mmb7MZpHnFY-AT-public.gmane.org>, Danny van Dyk <kugelfang-aBrp7R+bbdUdnm+yROfE0A-AT-public.gmane.org>, Andreas Jaggi <andreas.jaggi-xegAWGFB9mQXXHkOk0aIfQ-AT-public.gmane.org>, Larry Finger <larry.finger-tQ5ms3gMjBLk1uMJSBkQmQ-AT-public.gmane.org>, Quaker.Fang-xsfywfwIY+M-AT-public.gmane.org
Subject:  OpenBSD bcw: Possible GPL license violation issues
Date:  Wed, 4 Apr 2007 22:08:13 +0200
Cc:  Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q-AT-public.gmane.org>, Joseph Jezak <josejx-aBrp7R+bbdUdnm+yROfE0A-AT-public.gmane.org>, John Linville <linville-2XuSBdqkA4R54TAoqtyWWQ-AT-public.gmane.org>, Greg kh <greg-U8xfFu+wG4EAvxtiuMwx3w-AT-public.gmane.org>, bcm43xx-dev-0fE9KPoRgkgATYTw5x5z8w-AT-public.gmane.org, linux-wireless-u79uwXL29TY76Z2rM5mHXA-AT-public.gmane.org, license-violation-1yPg2kKgK35oVitdyIjqkB2eb7JE58TQ-AT-public.gmane.org
Archive-link:  Article, Thread

I, Michael Buesch, am one of the maintainers of the GPL'd Linux
wireless LAN driver for the Broadcom chip (bcm43xx).
The Copyright holders of bcm43xx (which includes me) want to talk
to you, OpenBSD bcw developers, about possible GPL license and therefore
Copyright violations in your bcw driver.

We believe that you might have directly copied code
out of bcm43xx (licensed under GPL v2), without our explicit permission,
into bcw (licensed under BSD license).
There are implementation details in bcm43xx that appear exactly
the same in bcw. These implementation details clearly don't come
from the open specifications at bcm-specs.sipsolutions.net
or bcm-v4.sipsolutions.net.

We have always made and still make a great effort to keep our code clean
of any Copyright issues (cleanroom design). Please make sure you also do.

A few examples follow of what we think might be GPL violations.
This list is far from being complete.

BCW_PHY_STACKSAVE()
BCW_ILT_STACKSAVE()
bcw_stack_save()
bcw_stack_restore()
These functions are a possible implementation of the specs when
they say "backup/restore a value".
Yet, it looks like you had exactly the same idea implementing this
generic description that I had.

bcw_set_opmode()
This function does not appear in the specifications.
I think Jiri Benc wrote it initially (and gave it its name) and
I extended it.

bcw_leds_switch_all()
is not in the specs, but a pure implementation detail of bcm43xx.

bcw_sprom_read()
This is obviously copied. Even the error message string is similiar.

bcw_phy_calc_loopback_gain()
I think it's no coincidence that you also decided to name the backup
variables like
	uint16_t backup_phy[15];
	uint16_t backup_radio[3];
	uint16_t backup_bband;

bcw_phy_init_pctl()
	uint16_t saved_batt = 0, saved_ratt = 0, saved_txctl1 = 0;
	int must_reset_txpower = 0;

bcw_phy_xmitpower()
Attenuation adjustment algorithms (while loops).

bcw_phy_lo_g_state()
This exactly matches bcm43xx, although the specs only have an abstract
description and diagram of the state machine.

bcw_phy_lo_g_deviation_subval()
/* XXX bcm43xx_voluntary_preempt() ? */
Nice comment there.
You might want to grep bcw for the string "bcm43xx"
and you will find more of them.


... and all the rest.


We'd like to have this issue resolved.
In general we are not against having a free (and BSD licensed) driver
in the BSD operating system. But you _have_ to cooperate with us if you'd
like to take our code and relicense it under BSD license. We intentionally
put the code under GPL license. We did _not_ do this, because "everybody
does this". We did this, among other reasons, because we
[citing Michael, Mon, 26 Dec 2005 13:03:44 +0100]
"don't think we should allow proprietary vendors to take our code
and close it again."

[citing Michael, Date unknown]
"What if Broadcom decides to take our LO measure state machine and
put it into the original driver? (The Rev Engineers told me they have
a very different weird solution for this in their code).
I really don't want to see this happen."

We'd like to offer you to start cooperating with us.
We respect you and your Copyright. You should also do so on our work.

We would not be opposed to relicensing parts of our code under the BSD
license on an explicit case-by-case base.
So if you ask "May I use this and that function" and if I own the
Copyright on that particular function, I will approve or deny your request.
Other Copyright holders of the bcm43xx code might act the same way.

We're not out for blood, just for a fair resolution.
We'd like you to start contacting us to resolve the issue now.

Have a nice day.

-- 
Greetings Michael.


(Log in to post comments)


Copyright © 2007, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds