User: Password:
|
|
Subscribe / Log in / New account

Sleepable RCU - A further correction in Cleaning Up Safely Section:

Sleepable RCU - A further correction in Cleaning Up Safely Section:

Posted Nov 8, 2006 6:09 UTC (Wed) by ds2horner (subscriber, #13438)
Parent article: Sleepable RCU

In the Cleaning Up Safely Section

"The readside() function overlaps an RCU and an SRCU read-side critical section, with the former running from lines 8-7 and the latter running from lines 6-9."

I believe references this code:
1 int readside(void) {
2 int idx;
3 rcu_read_lock();
4 if (nomoresrcu) {
5 rcu_read_unlock();
6 return -EINVAL;
7 }
8 idx = srcu_read_lock(&ss);
9 rcu_read_unlock();
10 /* SRCU read-side critical section. */
11 srcu_read_unlock(&ss, idx);
12 return 0;
13 }

I believe the correct references should be :

"The readside() function overlaps an RCU and an SRCU read-side critical section, with the former running from lines 8-_11_ and the latter running from lines _5_-9."

If I got this wrong, I _really_ am confused.

Thanks for the wonderful artice, and the great work!



(Log in to post comments)

Sleepable RCU - A further correction in Cleaning Up Safely Section:

Posted Feb 2, 2007 18:40 UTC (Fri) by PaulMcKenney (subscriber, #9624) [Link]

You are abolutely correct -- I guess I need to get my eyes checked! :-/


Copyright © 2017, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds