Re: [Bulk] Re: [PATCH 1/2] [PCI] Check that MWI bit really did get
set
[Posted October 17, 2006 by corbet]
| From: |
| Alan Cox <alan-AT-lxorguk.ukuu.org.uk> |
| To: |
| David Brownell <david-b-AT-pacbell.net> |
| Subject: |
| Re: [Bulk] Re: [PATCH 1/2] [PCI] Check that MWI bit really did get
set |
| Date: |
| Sun, 15 Oct 2006 15:21:22 +0100 |
| Cc: |
| matthew-AT-wil.cx, akpm-AT-osdl.org, val_henson-AT-linux.intel.com,
netdev-AT-vger.kernel.org, linux-pci-AT-atrey.karlin.mff.cuni.cz,
linux-kernel-AT-vger.kernel.org, gregkh-AT-suse.de |
Ar Sul, 2006-10-15 am 00:08 -0700, ysgrifennodd David Brownell:
> Since it's not an error, there should be no such printk ... which
> is exactly how it's coded above.
The underlying bug is that someone marked pci_set_mwi must-check, that's
wrong for most of the drivers that use it. If you remove the must check
annotation from it then the problem and a thousand other spurious
warnings go away.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
