Any results?

Posted Jun 2, 2006 0:33 UTC (Fri) by linportal (guest, #38148)
In reply to: Any results? by arjan
Parent article: The kernel lock validator

What I have missed in all this is the address to forward detected bugs to. What about this one: kseriod deadlock? Is it real or false positive?

to post comments

Any results?

Posted Jun 3, 2006 11:59 UTC (Sat) by mingo (subscriber, #31122) [Link]

That's a false positive, caused by recursive locking in the serio code. Arjan has posted the fix:

--- linux/drivers/input/serio/libps2.c.orig
+++ linux/drivers/input/serio/libps2.c
@@ -177,7 +177,7 @@ int ps2_command(struct ps2dev *ps2dev, u
                return -1;
        }

-       mutex_lock(&ps2dev->cmd_mutex);
+       mutex_lock_nested(&ps2dev->cmd_mutex, SINGLE_DEPTH_NESTING);

        serio_pause_rx(ps2dev->serio);
        ps2dev->flags = command == PS2_CMD_GETID ? PS2_FLAG_WAITID : 0;