|To:||Andi Kleen <ak-AT-suse.de>|
|Subject:||checklist (Re: 2.6.17-rc2-mm1)|
|Date:||Thu, 27 Apr 2006 12:44:52 -0700|
> > So at this point in time what I'd like to do is to encourage developers to > > do these very basic things. That's the low-hanging fruit right now. > > Write a checklist for that? I've been meaning to write up one myself, so I'll give it a shot. This is all above and beyond good patch log descriptions. 1. Build cleanly with applicable or modified CONFIG options =y, =m, and =n. No gcc warnings/errors, no linker warnings/errors. 2. Build on multiple CPU arch-es by using local cross-compile tools or something like PLM at OSDL. 3. Check cleanly with sparse. 4. Make sure that any new or modified CONFIG options don't muck up the config menu. 5. Use 'make checkstack' and 'make namespacecheck' and fix any problems that they find. Note: checkstack does not point out problems explicitly, but any one function that uses more than 512 bytes on the stack is a candidate for change. 6. Include kernel-doc to document global kernel APIs. (Not required for static functions, but OK there also.) Use 'make htmldocs' or 'make mandocs' to check the kernel-doc and fix any issues. --- ~Randy
Copyright © 2006, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds