Re: [PATCH] splice support #2
[Posted April 3, 2006 by corbet]
| From: |
| tridge-AT-samba.org |
| To: |
| linux-kernel-AT-vger.kernel.org |
| Subject: |
| Re: [PATCH] splice support #2 |
| Date: |
| Fri, 31 Mar 2006 17:06:24 +1100 |
Linus and Jens,
Stephen Rothwell just pointed me at the new splice() interface. Looks
really nice!
One comment though. Could we add a off_t to splice to make it more
like pwrite() ? Otherwise threads could get painful with race
conditions between the seek and the splice() call.
Either that or add psplice() like this:
ssize_t psplice(int fdin, int fdout, size_t len, off_t ofs, unsigned flags);
where ofs sets the offset to read from fdin.
Cheers, Tridge