User: Password:
Subscribe / Log in / New account

A pair of suspend2 patches

A pair of suspend2 patches

Posted Aug 1, 2005 17:42 UTC (Mon) by bronson (subscriber, #4806)
Parent article: A pair of suspend2 patches

Long function names like this usually indicate a flags parameter could be useful:

create_workqueue(NOFREEZE | SINGLETHREAD);

This tends to make the API more future-friendly too. Other than performance (which isn't too critical when creating workqueues), is there any reason to create 2^N function calls instead of N flags?

(Log in to post comments)

A pair of suspend2 patches

Posted Sep 15, 2005 7:23 UTC (Thu) by NCunningham (guest, #6457) [Link]

Sorry for the long delay in replying :)

I agree, but the consensus from others was that they view it as more important to minimise the changes to the api. Adding a _nofreeze variant lets us only change the functions that need to be unfreezable.



Copyright © 2017, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds