|From:||Russell King <rmk+lkml-AT-arm.linux.org.uk>|
|To:||Adrian Bunk <bunk-AT-stusta.de>|
|Subject:||Re: [2.6 patch] deprecate EXPORT_SYMBOL(do_settimeofday)|
|Date:||Sat, 26 Feb 2005 14:46:35 +0000|
|Cc:||Andrew Morton <akpm-AT-osdl.org>, linux-kernel-AT-vger.kernel.org|
On Sat, Feb 26, 2005 at 02:33:37PM +0100, Adrian Bunk wrote: > Signed-off-by: Adrian Bunk <firstname.lastname@example.org> Please don't deprecate this symbol. ARM has a large variety of RTC implementations, some of which reside in I2C modules which are yet to be merged. Firstly, these aren't accessible until the i2c subsystem has been initialised. Secondly, i2c is modular, so this function must be accessible from a module in order for the system time/date to be initialised from the RTC with a modular build. (It can be argued that you wouldn't want to build such a thing as a module in the first place, in which case removing the export would of course be fine. However, we can't sanely force I2C to be either always builtin, and placing this expectation on people will eventually lead other janitors to complain that the symbol is used by modules but isn't exported.) -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/ 2.6 Serial core
Copyright © 2005, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds