User: Password:
Subscribe / Log in / New account

Re: [PATCH] fs: Restore files_lock and set_fs_root exports

From:  Linus Torvalds <>
To:  Alan Cox <>
Subject:  Re: [PATCH] fs: Restore files_lock and set_fs_root exports
Date:  Thu, 6 Jan 2005 16:24:58 -0800 (PST)
Cc:  Andrew Morton <>, Al Viro <>,,, Linux Kernel Mailing List <>,,,,,
Archive-link:  Article, Thread

On Thu, 6 Jan 2005, Alan Cox wrote:

> On Iau, 2005-01-06 at 23:26, Andrew Morton wrote:
> > I think the exports should be restored.  So does Linus ("Not that I like
> > all that much, but I don't think we should break existing modules unless
> > have a very specific reason to break just those modules.").
> What happens when the feature is just not (ab)usable in the way proposed ? 

At that point there is a specific _reason_ to break it, aka "that function 
simply doesn't exist any more".

I'm known for happily breaking binary modules, but I think we should do it 
only if we have a reason _other_ than "let's break a module". 


(Log in to post comments)

Copyright © 2005, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds