| From: |
| Michael Margolin <mrgolin-AT-amazon.com> |
| To: |
| <jgg-AT-nvidia.com>, <leon-AT-kernel.org>, <linux-rdma-AT-vger.kernel.org> |
| Subject: |
| [PATCH for-next v5 0/5] Introduce Completion Counters |
| Date: |
| Tue, 26 May 2026 09:07:07 +0000 |
| Message-ID: |
| <20260526090712.17575-1-mrgolin@amazon.com> |
| Cc: |
| <sleybo-AT-amazon.com>, <matua-AT-amazon.com>, <gal.pressman-AT-linux.dev> |
| Archive-link: |
| Article |
Add core infrastructure for Completion Counters, a light-weight
alternative to polling CQ for tracking operation completions. The
related rdma-core support is linked in [1].
Define the UVERBS_OBJECT_COMP_CNTR ioctl object with create, destroy,
modify and read methods for both success and error counters. Add a QP
attach method on the QP object to associate a completion counter with a
queue pair.
Add EFA Completion Counters support as first implementer.
[1] https://github.com/linux-rdma/rdma-core/pull/1701
---
Changes in v5:
- Fixed Sashiko findings
- Minor naming improvements
Changes in v4:
- Replaced inc and set commands by a single modify command
- Changed to passing buffers as EFA specific attributes using desc
struct aligned with the suggested common method of passing and
consuming umem in RDMA drivers
- Link to v2: https://lore.kernel.org/all/20260416212327.18191-1-mrgoli...
Changes in v3:
- Skipped this version because of a wrong patch list
Changes in v2:
- United set, inc and read flows for successful and error completions
counters
- Added comp_cntr usage count
- Minor cleanups
- Link to v1: https://lore.kernel.org/all/20260407115424.13359-1-mrgoli...
Michael Margolin (5):
RDMA/core: Add Completion Counters support
RDMA/core: Prevent destroying in-use completion counters
RDMA/core: Add Completion Counters to resource tracking
RDMA/efa: Update device interface
RDMA/efa: Add Completion Counters support
drivers/infiniband/core/Makefile | 1 +
drivers/infiniband/core/device.c | 6 +
drivers/infiniband/core/nldev.c | 1 +
drivers/infiniband/core/rdma_core.h | 1 +
drivers/infiniband/core/restrack.c | 2 +
drivers/infiniband/core/uverbs_cmd.c | 1 +
.../core/uverbs_std_types_comp_cntr.c | 182 ++++++++++++++
drivers/infiniband/core/uverbs_std_types_qp.c | 62 ++++-
drivers/infiniband/core/uverbs_uapi.c | 1 +
drivers/infiniband/core/verbs.c | 8 +
drivers/infiniband/hw/efa/efa.h | 15 ++
.../infiniband/hw/efa/efa_admin_cmds_defs.h | 185 +++++++++++++-
drivers/infiniband/hw/efa/efa_com_cmd.c | 110 ++++++++
drivers/infiniband/hw/efa/efa_com_cmd.h | 36 +++
drivers/infiniband/hw/efa/efa_io_defs.h | 61 ++++-
drivers/infiniband/hw/efa/efa_main.c | 5 +
drivers/infiniband/hw/efa/efa_verbs.c | 234 ++++++++++++++++++
include/rdma/ib_verbs.h | 44 ++++
include/rdma/restrack.h | 4 +
include/uapi/rdma/efa-abi.h | 19 ++
include/uapi/rdma/ib_user_ioctl_cmds.h | 38 +++
include/uapi/rdma/ib_user_ioctl_verbs.h | 19 ++
include/uapi/rdma/ib_user_verbs.h | 2 +-
23 files changed, 1030 insertions(+), 7 deletions(-)
create mode 100644 drivers/infiniband/core/uverbs_std_types_comp_cntr.c
--
2.47.3
