|From:||Dave Hansen <haveblue-AT-us.ibm.com>|
|To:||Marcelo Tosatti <marcelo.tosatti-AT-cyclades.com>|
|Subject:||Re: [RFC] memory defragmentation to satisfy high order allocations|
|Date:||Fri, 01 Oct 2004 14:57:03 -0700|
|Cc:||Andrew Morton <akpm-AT-osdl.org>, linux-mm <linux-mm-AT-kvack.org>, piggin-AT-cyberone.com.au, Arjan van de Ven <arjanv-AT-redhat.com>, Linux Kernel Mailing List <linux-kernel-AT-vger.kernel.org>|
On Fri, 2004-10-01 at 12:04, Marcelo Tosatti wrote: > On Fri, Oct 01, 2004 at 01:11:47PM -0700, Andrew Morton wrote: > > Presumably this duplicates some of the memory hot-remove patches. > > As far as I have researched, the memory moving/remapping code > on the hot remove patches dont work correctly. Please correct me. I definitely see some commonality, but Marcelo's approach has handling for the different kinds of pages broken out much more nicely. Can't tell yet if this produces extra code, or is just plain better. We worked pretty hard to try and copy as little code as possible. Was there any reason that there was so much stuff copied out of rmap.c? Just for proof-of-concept? Here's one of the recent patch sets that we're working on: http://sprucegoose.sr71.net/patches/2.6.9-rc2-mm4-mhp-test2/ In that directory, the K* patches hijack some of the swap code (but require memory pressure to work last time I tried), and the p000* patches (by Hirokazu Takahashi) actively migrate pages around. Both approaches work, but the K* one is smaller and less intrusive, while the p000* one is much more complete. They may end up being able to coexist in the end. > And what I've seen (from the Fujitsu guys) was quite ugly IMHO. I don't work for Fujitsu :) Please take a look at the patches in the above directory and see what you think. I'm sure you have some very good stuff in your patch, but I need to take a closer look. I'm just about to head out of town for the weekend, but I'll take a much more detailed look on Monday. -- Dave Hansen firstname.lastname@example.org - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to email@example.com More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Copyright © 2004, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds